GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build,tools: update make-v8.sh for ppc64le by refack · Pull Request #24293 · nodejs/node

Conversation

refack commented Nov 10, 2018

Copy link

Copy Markdown

Contributor

Follow up to #23839
Fixes: nodejs/build#1536

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented Nov 10, 2018

Copy link

Copy Markdown

Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1573/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added tools

Issues and PRs related to the tools directory.

v8 engine Issues and PRs related to the V8 dependency. labels

Nov 10, 2018

refack requested review from gdams and mhdawson

November 10, 2018 22:16

refack self-assigned this

Nov 10, 2018

refack added the build Issues and PRs related to Node.js builds or CI infrastructure. label

Nov 10, 2018

refack commented Nov 10, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

V8 CI (with temporary config to use this file):
~~https://ci.nodejs.org/job/node-test-commit-v8-linux/1837/~~
https://ci.nodejs.org/job/node-test-commit-v8-linux/1838/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

refack mentioned this pull request

Nov 10, 2018

CI-Change: tweaks to make-v8 test script nodejs/build#1536

Closed

bnoordhuis approved these changes

Nov 12, 2018

View reviewed changes

Comment thread

tools/make-v8.sh

		ln -s /usr/bin/$CC "$BUILD_TOOLS/gcc"
		g++ --version
		export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config-files
		gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64"'

bnoordhuis Nov 12, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to figure out how V8 knows the endianness, since it's not specified on the command line.

I thought it checked compiler defines but no, it's defined in build/config/host_byteorder.gni and it basically assumes LE unless the host arch is one of a select few. ppc64 is not one of the select except when os=AIX.

(And yes, host arch, not target arch. It's not cross-compile ready.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson approved these changes

Nov 12, 2018

View reviewed changes

mhdawson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

fhinkel approved these changes

Nov 13, 2018

View reviewed changes

refack commented Nov 14, 2018

Copy link

Copy Markdown

Contributor Author

Lite-CI (since it's only used by test-v8 anyway): https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1615/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

refack force-pushed the update-tools-make-v8-part2 branch from c8550fa to b5ecf2e Compare

November 14, 2018 18:31

refack force-pushed the update-tools-make-v8-part2 branch from b5ecf2e to c8550fa Compare

November 16, 2018 19:06


          build,tools: update make-v8.sh for ppc64le

3d4b281

PR-URL: nodejs#24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

refack force-pushed the update-tools-make-v8-part2 branch from c8550fa to 3d4b281 Compare

November 16, 2018 19:31

refack removed the request for review from gdams

November 16, 2018 20:24

refack merged commit 3d4b281 into nodejs:master

Nov 16, 2018

refack deleted the update-tools-make-v8-part2 branch

November 16, 2018 20:24

refack removed their assignment

Nov 16, 2018

targos pushed a commit that referenced this pull request

Nov 18, 2018


          build,tools: update make-v8.sh for ppc64le

98fa7f7

PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

rvagg pushed a commit that referenced this pull request

Nov 28, 2018


          build,tools: update make-v8.sh for ppc64le

331b26e

PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

BridgeAR mentioned this pull request

Dec 5, 2018

v11.4.0 proposal #24854

Merged

4 tasks done

This was referenced Dec 7, 2018

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265

Closed

codebytere pushed a commit that referenced this pull request

Jan 12, 2019


          build,tools: update make-v8.sh for ppc64le

4d31b3a

PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

codebytere mentioned this pull request

Jan 15, 2019

v10.15.1 proposal #25346

Merged

codebytere pushed a commit that referenced this pull request

Jan 29, 2019


          build,tools: update make-v8.sh for ppc64le

dc5647f

PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

This was referenced Jan 29, 2019

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262

Closed

Reviewers

bnoordhuis

bnoordhuis approved these changes

+2 more reviewers

fhinkel

fhinkel approved these changes

mhdawson

mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

tools

Issues and PRs related to the tools directory.

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI-Change: tweaks to make-v8 test script

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

refack commented Nov 10, 2018

Checklist

Uh oh!

nodejs-github-bot commented Nov 10, 2018

Uh oh!

refack commented Nov 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnoordhuis Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Nov 14, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refack commented Nov 10, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.