GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: upgrade to libuv 1.24.0 by cjihrig · Pull Request #24332 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Nov 13, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji bricss reacted with hooray emoji bricss reacted with heart emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2018

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1591/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Nov 13, 2018
refack
refack approved these changes Nov 13, 2018
View reviewed changes
santigimeno
santigimeno approved these changes Nov 13, 2018
View reviewed changes
@targos

targos commented Nov 13, 2018 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18573/ (:heavy_check_mark:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Nov 13, 2018
View reviewed changes
addaleax
addaleax approved these changes Nov 13, 2018
View reviewed changes
@addaleax

addaleax commented Nov 13, 2018

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1616/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Nov 13, 2018
View reviewed changes

@trivikr trivikr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bricss bricss mentioned this pull request Nov 14, 2018
Release proposal: v11.2 #24350
Merged
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 15, 2018
@Trott

Trott commented Nov 15, 2018

Copy link
Copy Markdown
Member

@nodejs/citgm Any comments on the CITGM results?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
deps: upgrade to libuv 1.24.0
9cef7b8 
PR-URL: nodejs#24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@cjihrig
cjihrig force-pushed the libuv branch from bd4f89a to 9cef7b8 Compare November 15, 2018 19:53
@cjihrig
cjihrig merged commit 9cef7b8 into nodejs:master Nov 15, 2018
@cjihrig
cjihrig deleted the libuv branch November 15, 2018 19:55
targos pushed a commit that referenced this pull request Nov 18, 2018
@cjihrig @targos
deps: upgrade to libuv 1.24.0
b73a6e1 
PR-URL: #24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@cjihrig @rvagg
deps: upgrade to libuv 1.24.0
06c28b9 
PR-URL: #24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
@BridgeAR BridgeAR added the backport-requested-v11.x label Dec 7, 2018
@BridgeAR

BridgeAR commented Dec 7, 2018

Copy link
Copy Markdown
Member

It seems like this patch breaks a test on Node.js 11 on OS-X (https://ci.nodejs.org/job/node-test-commit-osx/23290/nodes=osx1011/console).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Dec 7, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The change landed after the update, so @targos and me decided to keep libuv but to pull out the change with the failing test. Please nevertheless have a close look at the failing test #20640.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR removed the backport-requested-v11.x label Dec 7, 2018
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@cjihrig @codebytere
deps: upgrade to libuv 1.24.0
72f10a4 
PR-URL: #24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 29, 2019
@MylesBorins

MylesBorins commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

Should this be semver-minor? I feel like updated libuv should be but we haven't had an explicit policy around it. Happy to open another issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig @BethGriggs
deps: upgrade to libuv 1.24.0
fcb61f8 
PR-URL: #24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
deps: upgrade to libuv 1.24.0
3f3f833 
PR-URL: #24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
v10.16.0 proposal #27514
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2019
Should libuv upgrades be semver-minor? nodejs/Release#443
Closed
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
deps: upgrade to libuv 1.24.0
74f4741 
PR-URL: #24332
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced May 29, 2019
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315
Closed
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316
Closed
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317
Closed
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318
Closed
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@addaleax addaleax addaleax approved these changes
@santigimeno santigimeno santigimeno approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@refack refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. libuv Issues and PRs related to the libuv dependency or the uv binding. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@cjihrig @nodejs-github-bot @targos @addaleax @Trott @BridgeAR @MylesBorins @refack @bnoordhuis @santigimeno @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.