GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: correctly pause and resume after once('readable') by mcollina · Pull Request #24366 · nodejs/node

Conversation

mcollina commented Nov 14, 2018

Copy link

Copy Markdown

Member

Fixes: #24281

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          stream: correctly pause and resume after once('readable')

79c5c4b

Fixes: nodejs#24281

nodejs-github-bot commented Nov 14, 2018

Copy link

Copy Markdown

Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1611/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the stream Issues and PRs related to Node.js streams. label

Nov 14, 2018

mcollina mentioned this pull request

Nov 14, 2018

stream.resume() doesn't make the stream flowing after removing readable listener #24281

Closed

mcollina requested review from addaleax and mafintosh

November 14, 2018 16:31

addaleax approved these changes

Nov 14, 2018

View reviewed changes

addaleax left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like there might be some simplification possible here, but I’m not seeing it right away :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

fhinkel approved these changes

Nov 16, 2018

View reviewed changes

tvald mentioned this pull request

Nov 19, 2018

stream: adding new 'data' handler doesn't resume stream after removing 'readable' handler #24474

Closed

mcollina commented Nov 20, 2018

Copy link

Copy Markdown

Member Author

Ci: https://ci.nodejs.org/job/node-test-pull-request/18811/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina commented Nov 21, 2018

Copy link

Copy Markdown

Member Author

Landed in 69cc58d

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina closed this

Nov 21, 2018

mcollina deleted the resume-after-readable branch

November 21, 2018 11:17

mcollina added a commit that referenced this pull request

Nov 21, 2018


          stream: correctly pause and resume after once('readable')

69cc58d

Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

targos pushed a commit that referenced this pull request

Nov 21, 2018


          stream: correctly pause and resume after once('readable')

aa4d662

Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

rvagg pushed a commit that referenced this pull request

Nov 28, 2018


          stream: correctly pause and resume after once('readable')

ba1ebb4

Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

BridgeAR mentioned this pull request

Dec 5, 2018

v11.4.0 proposal #24854

Merged

4 tasks done

This was referenced Dec 7, 2018

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265

Closed

mcollina added lts-watch-v10.x labels

Jan 11, 2019

mcollina commented Jan 11, 2019

Copy link

Copy Markdown

Member Author

@nodejs/lts @nodejs/backporters @nodejs/releasers can you please include this in the next 10.x patch release?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codebytere pushed a commit that referenced this pull request

Jan 13, 2019


          stream: correctly pause and resume after once('readable')

30455be

Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019


          stream: correctly pause and resume after once('readable')

96c5c7e

Fixes: nodejs#24281

PR-URL: nodejs#24366
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

codebytere mentioned this pull request

Jan 15, 2019

v10.15.1 proposal #25346

Merged

codebytere pushed a commit that referenced this pull request

Jan 29, 2019


          stream: correctly pause and resume after once('readable')

fa60eb8

Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

This was referenced Jan 29, 2019

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262

Closed

mcollina mentioned this pull request

Feb 9, 2019

stream: readable.resume() not allowing 'end' to be emitted after readable.unshift() #25642

Closed

BethGriggs removed the lts-watch-v10.x label

Jul 9, 2019

Reviewers

addaleax

addaleax approved these changes

mafintosh

Awaiting requested review from mafintosh

+1 more reviewer

fhinkel

fhinkel approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stream

Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream.resume() doesn't make the stream flowing after removing readable listener

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.