GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add help on fixing IPv6 test failures by mhdawson · Pull Request #24372 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Nov 14, 2018

Copy link
Copy Markdown
Member

It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
doc: add help on fixing IPv6 test failures
db56b46 
It took me a while to figure out the problem and
then some googling to find the right answer.  I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2018

Copy link
Copy Markdown
Collaborator

@mhdawson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1618/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Nov 14, 2018
vsemozhetbyt
vsemozhetbyt reviewed Nov 14, 2018
View reviewed changes
Comment thread BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt and others added 3 commits November 15, 2018 09:19
@vsemozhetbyt @mhdawson
squash: accept suggestion
60caa23 
Co-Authored-By: mhdawson <[email protected]>
@vsemozhetbyt @mhdawson
squash: accept suggestion
5fe1c41 
Co-Authored-By: mhdawson <[email protected]>
@vsemozhetbyt @mhdawson
squash: accept suggestion
45d4a58 
Co-Authored-By: mhdawson <[email protected]>
@mhdawson

mhdawson commented Nov 15, 2018

Copy link
Copy Markdown
Member Author

@vsemozhetbyt thanks for the review, accepted all of your suggestions.
vsemozhetbyt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thefourtheye
thefourtheye approved these changes Nov 15, 2018
View reviewed changes
Comment thread BUILDING.md Outdated
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
loopback interface on Ubuntu using:

`sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0`

@thefourtheye thefourtheye Nov 15, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be better if we formatted this as console text, instead of inline code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhdawson mhdawson Nov 15, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
squash: address comments
5087aac
@mhdawson

mhdawson commented Nov 15, 2018

Copy link
Copy Markdown
Member Author

@vsemozhetbyt any chance you can add your approval as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 15, 2018
View reviewed changes
Trott
Trott reviewed Nov 16, 2018
View reviewed changes
Comment thread BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Nov 16, 2018
View reviewed changes
Comment thread BUILDING.md Outdated
The tests attempt to detect support for IPv6 and exclude IPv6 tests if
appropriate. However, if your main interface has IPv6 addresses then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the

@Trott Trott Nov 16, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
on Ubuntu, that does not seem to be the case. '::1' can be enabled on the

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott reviewed Nov 16, 2018
View reviewed changes
Comment thread BUILDING.md Outdated
appropriate. However, if your main interface has IPv6 addresses then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
loopback interface on Ubuntu using:

@Trott Trott Nov 16, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the last sentence with this?

To enable '::1' on the loopback interface on Ubuntu:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@fhinkel fhinkel Nov 16, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least

You can enable...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhdawson mhdawson Nov 16, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I had something like "You can .." but guidance is not to use you. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fhinkel
fhinkel approved these changes Nov 16, 2018
View reviewed changes
Comment thread BUILDING.md Outdated
appropriate. However, if your main interface has IPv6 addresses then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
loopback interface on Ubuntu using:

@fhinkel fhinkel Nov 16, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least

You can enable...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott and others added 2 commits November 16, 2018 09:19
@Trott @mhdawson
squash: address changes
e51ba22 
Co-Authored-By: mhdawson <[email protected]>
@mhdawson
squash: address comments
0aaae27
@mhdawson

mhdawson commented Nov 16, 2018

Copy link
Copy Markdown
Member Author

Comments addressed. Like CI run: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1632/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Nov 16, 2018

Copy link
Copy Markdown
Member Author

CI good landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Nov 16, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Landed as 6b4e413
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Nov 16, 2018
mhdawson added a commit that referenced this pull request Nov 16, 2018
@mhdawson
doc: add help on fixing IPv6 test failures
6b4e413 
It took me a while to figure out the problem and
then some googling to find the right answer.  I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.

PR-URL: #24372
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@mhdawson @targos
doc: add help on fixing IPv6 test failures
60aebd8 
It took me a while to figure out the problem and
then some googling to find the right answer.  I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.

PR-URL: #24372
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mhdawson @rvagg
doc: add help on fixing IPv6 test failures
5f747f1 
It took me a while to figure out the problem and
then some googling to find the right answer.  I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.

PR-URL: #24372
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
This was referenced Dec 8, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
@codebytere codebytere added the dont-land-on-v10.x label Jan 12, 2019
@mhdawson
mhdawson deleted the building-ipv6 branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments
@lpinca lpinca lpinca approved these changes
+3 more reviewers
@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments
@fhinkel fhinkel fhinkel approved these changes
@thefourtheye thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mhdawson @nodejs-github-bot @fhinkel @thefourtheye @Trott @lpinca @vsemozhetbyt @codebytere
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.