GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: assertion equality fix by NoSkillGirl · Pull Request #24422 · nodejs/node

Conversation

@NoSkillGirl

@NoSkillGirl NoSkillGirl commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

In test-net-write-callback.js, when the process exits, we check of callback
count with the expected value. written assert.strictEqual(N, cbcount),
which expects N to equal to cbcount, instead we should expect cbcount to be equal to cbcount.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@NoSkillGirl
test: assertion equality fix
7867740 
In test-net-write-callback.js, when process exits, we check of callback
count with the expected value. written assert.strictEqual(N, cbcount),
which expects N to equal to cbcount, instead we should expect cbcount to be equal to cbcount.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Commit message should look like test: fix ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

👍 to fast-track
gireeshpunathil and oyyd reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 17, 2018
gireeshpunathil
gireeshpunathil approved these changes Nov 18, 2018
View reviewed changes
@Trott

Trott commented Nov 18, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18717/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Nov 18, 2018
View reviewed changes
oyyd
oyyd approved these changes Nov 18, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Nov 18, 2018
View reviewed changes
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@NoSkillGirl @Trott
test: assertion equality fix
dafd76c 
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: nodejs#24422
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

Landed in dafd76c. (I edited the commit message.)

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 19, 2018
targos pushed a commit that referenced this pull request Nov 19, 2018
@NoSkillGirl @targos
test: assertion equality fix
ef32021 
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: #24422
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@NoSkillGirl

NoSkillGirl commented Nov 21, 2018

Copy link
Copy Markdown
Contributor Author

Hi @gireeshpunathil, Is this pull request merged or closed ? @Trott edited the commit message and the PR got reviewed by multiple people. @Trott kept a "Thanks for the contribution!" message But i see the PR got closed with unmerged commits.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 21, 2018

Copy link
Copy Markdown
Member

@NoSkillGirl The "closed" is an artifact of the way I merged the commit, but it's really there in master. See dafd76c.
NoSkillGirl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@NoSkillGirl @rvagg
test: assertion equality fix
9b2ab12 
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: #24422
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@NoSkillGirl @codebytere
test: assertion equality fix
7c8157f 
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: #24422
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@NoSkillGirl @refack
test: assertion equality fix
75bd4c3 
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: nodejs#24422
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@NoSkillGirl @codebytere
test: assertion equality fix
52259d7 
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: #24422
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@beevelop beevelop mentioned this pull request Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280
Closed
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@trivikr trivikr trivikr approved these changes
+2 more reviewers
@targos targos targos approved these changes
@oyyd oyyd oyyd approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@NoSkillGirl @targos @Trott @cjihrig @oyyd @gireeshpunathil @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.