GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src:Elevate v8 namespaces of repeatedly referenced artifacts with by manilson · Pull Request #24429 · nodejs/node

Conversation

@manilson

@manilson manilson commented Nov 17, 2018

Copy link
Copy Markdown

'using' keyword in src/node_i18n.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to Node.js internationalization support. labels Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos reviewed Nov 17, 2018
View reviewed changes
Comment thread src/node_i18n.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

The commit message should start with src: elevate ... and its first line should be shorter (max 50 characters)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
refack
refack approved these changes Nov 17, 2018
View reviewed changes

@refack refack left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % duplicate line

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@refack refack added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 17, 2018
@refack

refack commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Please 👍 for fast-track (nits could be resolved during landing)
targos, gireeshpunathil, oyyd, and thefourtheye reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack

refack commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Lite CI:https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Nov 18, 2018
View reviewed changes
jasnell
jasnell approved these changes Nov 19, 2018
View reviewed changes
@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18771/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack

refack commented Nov 19, 2018

Copy link
Copy Markdown
Contributor

Hello @manilson and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.

P.P.S. If you like you can associate your email address with you GitHub account. That way your contributions will be properly credited to you. See https://help.github.com/articles/setting-your-commit-email-address-on-github/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack refack added blocked PRs that are blocked by other issues or PRs. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Nov 19, 2018
@refack

refack commented Nov 19, 2018

Copy link
Copy Markdown
Contributor

blocking to give the OP a chance to set their email address.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thefourtheye
thefourtheye approved these changes Nov 20, 2018
View reviewed changes
Maya Anilson @manilson
src: elevate namespaces of repeated artifacts
4cd7be8
@manilson
manilson force-pushed the master branch from bb5dffe to 4cd7be8 Compare November 20, 2018 11:07
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label Nov 20, 2018
@addaleax

addaleax commented Nov 20, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18804/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 20, 2018
@Trott

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

Landed in 77c2cf9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 20, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018
Maya Anilson @Trott
src: elevate namespaces of repeated artifacts
77c2cf9 
PR-URL: nodejs#24429
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit that referenced this pull request Nov 21, 2018
Maya Anilson @targos
src: elevate namespaces of repeated artifacts
6a5a50d 
PR-URL: #24429
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Maya Anilson @rvagg
src: elevate namespaces of repeated artifacts
b8ed930 
PR-URL: #24429
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
Maya Anilson @codebytere
src: elevate namespaces of repeated artifacts
ff4eeae 
PR-URL: #24429
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Maya Anilson @refack
src: elevate namespaces of repeated artifacts
2a68866 
PR-URL: nodejs#24429
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Maya Anilson @codebytere
src: elevate namespaces of repeated artifacts
4b82aa8 
PR-URL: #24429
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
@refack refack refack approved these changes
@targos targos targos left review comments
@thefourtheye thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. i18n-api Issues and PRs related to Node.js internationalization support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@manilson @targos @refack @Trott @addaleax @jasnell @thefourtheye @gireeshpunathil @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.