GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: Using arrow functions by NoSkillGirl · Pull Request #24436 · nodejs/node

Conversation

NoSkillGirl commented Nov 17, 2018

Copy link

Copy Markdown

Contributor

Using arrow functions in test-tls-client-resume.js

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label

Nov 17, 2018

gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label

Nov 17, 2018

targos reviewed

Nov 17, 2018

View reviewed changes

targos left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should look like test: use arrow functions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/parallel/test-tls-client-resume.js Outdated

targos Nov 17, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));
	const server = tls.Server(options, common.mustCall(socket => socket.end('Goodbye'), 2));

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

NoSkillGirl force-pushed the testcase-arrowfunctions branch from 0ee9e42 to 75cf1d4 Compare

November 20, 2018 23:55

NoSkillGirl force-pushed the testcase-arrowfunctions branch from 75cf1d4 to 362b69d Compare

November 21, 2018 00:02

NoSkillGirl force-pushed the testcase-arrowfunctions branch from 0d6b3c8 to 272d172 Compare

November 21, 2018 02:15

NoSkillGirl force-pushed the testcase-arrowfunctions branch from 272d172 to e12f560 Compare

November 21, 2018 06:48

gireeshpunathil commented Nov 21, 2018

Copy link

Copy Markdown

Member

ping @NoSkillGirl

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

NoSkillGirl force-pushed the testcase-arrowfunctions branch from e12f560 to 0dbe2f8 Compare

November 21, 2018 15:28

NoSkillGirl commented Nov 21, 2018

Copy link

Copy Markdown

Contributor Author

Pong @gireeshpunathil

gireeshpunathil and trivikr reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gireeshpunathil approved these changes

Nov 21, 2018

View reviewed changes


           test: using arrow functions

d91a981

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

    PR-URL: nodejs#24436

NoSkillGirl force-pushed the testcase-arrowfunctions branch from 0dbe2f8 to d91a981 Compare

November 21, 2018 16:22

jasnell approved these changes

Nov 21, 2018

View reviewed changes

danbev commented Nov 22, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/18866/ ✔️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbev commented Nov 22, 2018

Copy link

Copy Markdown

Contributor

Landed in 282e533. 🎉

NoSkillGirl reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbev closed this

Nov 22, 2018

danbev pushed a commit that referenced this pull request

Nov 22, 2018


          test: using arrow functions

282e533

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

NoSkillGirl commented Nov 22, 2018

Copy link

Copy Markdown

Contributor Author

Thank You @danbev

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

Nov 24, 2018


          test: using arrow functions

82ed615

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

rvagg pushed a commit that referenced this pull request

Nov 28, 2018


          test: using arrow functions

1cd73a8

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

BridgeAR mentioned this pull request

Dec 5, 2018

v11.4.0 proposal #24854

Merged

4 tasks done

This was referenced Dec 7, 2018

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263

Closed

This was referenced Dec 8, 2018

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265

Closed

codebytere pushed a commit that referenced this pull request

Jan 13, 2019


          test: using arrow functions

6e7d867

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019


          test: using arrow functions

f4319d7

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: nodejs#24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

codebytere mentioned this pull request

Jan 15, 2019

v10.15.1 proposal #25346

Merged

codebytere pushed a commit that referenced this pull request

Jan 29, 2019


          test: using arrow functions

0a2cd50

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

codebytere pushed a commit that referenced this pull request

Jan 29, 2019


          test: using arrow functions

8bd2399

    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This was referenced Jan 29, 2019

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262

Closed

Reviewers

jasnell

jasnell approved these changes

gireeshpunathil

gireeshpunathil approved these changes

+1 more reviewer

targos

targos left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

NoSkillGirl commented Nov 17, 2018

Checklist

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

targos Nov 17, 2018

Choose a reason for hiding this comment

Uh oh!

gireeshpunathil commented Nov 21, 2018

Uh oh!

NoSkillGirl commented Nov 21, 2018

Uh oh!

danbev commented Nov 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danbev commented Nov 22, 2018

Uh oh!

NoSkillGirl commented Nov 22, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

danbev commented Nov 22, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.