GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — util: remove unreachable branch by rahulshuklab4u · Pull Request #24447 · nodejs/node

Conversation

@rahulshuklab4u

@rahulshuklab4u rahulshuklab4u commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 17, 2018
@Trott

Trott commented Nov 17, 2018

Copy link
Copy Markdown
Member

/ping @nodejs/util (especially @BridgeAR)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Nov 17, 2018
View reviewed changes
refack
refack approved these changes Nov 17, 2018
View reviewed changes
@refack
refack requested a review from BridgeAR November 17, 2018 23:40
@refack

refack commented Nov 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

Also since value passes an isArray test, it is guaranteed to have a non negative, defined length property

node/lib/internal/util/inspect.js

Lines 476 to 479 in bde132b

} else if (Array.isArray(value)) {
const clazz = Object.getPrototypeOf(value) ||
clazzWithNullPrototype(Array, 'Array');
newVal = new clazz(value.length || 0);

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack

refack commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Hello @rahulshuklab4u and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
starkwang
starkwang approved these changes Nov 18, 2018
View reviewed changes
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2018
jasnell
jasnell approved these changes Nov 19, 2018
View reviewed changes
sagirk
sagirk approved these changes Nov 19, 2018
View reviewed changes
@addaleax

addaleax commented Nov 20, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18801/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 20, 2018
@rahulshuklab4u @refack
util: remove unreachable branch
fbc2916 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: nodejs#24447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack
refack force-pushed the master branch from 58b3b9f to fbc2916 Compare November 20, 2018 17:50
@refack refack removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 20, 2018
@refack
refack merged commit fbc2916 into nodejs:master Nov 20, 2018
@refack

refack commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Congratulations @rahulshuklab4u on getting promoted by GitHub from:
image
to:
image

🎉
sagirk and gireeshpunathil reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 21, 2018
@rahulshuklab4u @targos
util: remove unreachable branch
519b621 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rahulshuklab4u @rvagg
util: remove unreachable branch
9e8f91d 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@rahulshuklab4u @codebytere
util: remove unreachable branch
734fe5f 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@rahulshuklab4u @refack
util: remove unreachable branch
7a0d9d3 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: nodejs#24447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@rahulshuklab4u @codebytere
util: remove unreachable branch
eeb4715 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@BridgeAR BridgeAR Awaiting requested review from BridgeAR
+3 more reviewers
@refack refack refack approved these changes
@sagirk sagirk sagirk approved these changes
@starkwang starkwang starkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@rahulshuklab4u @Trott @refack @addaleax @jasnell @sagirk @starkwang @gireeshpunathil @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.