GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix test case in test-child-process-fork-dgram.js by gengjiawen · Pull Request #24459 · nodejs/node

Conversation

@gengjiawen

@gengjiawen gengjiawen commented Nov 18, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
leeight reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 18, 2018
@gengjiawen
gengjiawen force-pushed the bugfix/test-case-child-process branch from ff8fe69 to 53f777a Compare November 18, 2018 08:07
trivikr
trivikr approved these changes Nov 19, 2018
View reviewed changes
jasnell
jasnell approved these changes Nov 19, 2018
View reviewed changes
lpinca
lpinca approved these changes Nov 19, 2018
View reviewed changes
lpinca
lpinca reviewed Nov 19, 2018
View reviewed changes
Comment thread test/parallel/test-child-process-fork-dgram.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Nov 19, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18741/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen

gengjiawen commented Nov 20, 2018

Copy link
Copy Markdown
Member Author

@lpinca Do I need to squash my commits ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Nov 20, 2018

Copy link
Copy Markdown
Member

@gengjiawen it would be nice, it will help whoever lands this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen
test: fix test case in test-child-process-fork-dgram.js
758939b
@gengjiawen
gengjiawen force-pushed the bugfix/test-case-child-process branch from dc96de1 to 758939b Compare November 20, 2018 14:50
@gengjiawen

gengjiawen commented Nov 20, 2018

Copy link
Copy Markdown
Member Author

@lpinca done.
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Nov 23, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18893/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 23, 2018
@addaleax

addaleax commented Nov 23, 2018

Copy link
Copy Markdown
Member

Landed in 4270c13, thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Nov 23, 2018
addaleax pushed a commit that referenced this pull request Nov 23, 2018
@gengjiawen @addaleax
test: fix test case in test-child-process-fork-dgram.js
4270c13 
PR-URL: #24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 24, 2018
@gengjiawen @targos
test: fix test case in test-child-process-fork-dgram.js
b5d6035 
PR-URL: #24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@gengjiawen @rvagg
test: fix test case in test-child-process-fork-dgram.js
34b40af 
PR-URL: #24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@gengjiawen @codebytere
test: fix test case in test-child-process-fork-dgram.js
3f2809b 
PR-URL: #24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@gengjiawen @refack
test: fix test case in test-child-process-fork-dgram.js
729d43d 
PR-URL: nodejs#24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@gengjiawen @codebytere
test: fix test case in test-child-process-fork-dgram.js
8da2933 
PR-URL: #24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@gengjiawen @codebytere
test: fix test case in test-child-process-fork-dgram.js
559ca1c 
PR-URL: #24459
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@jasnell jasnell jasnell approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@gengjiawen @lpinca @addaleax @jasnell @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.