GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: edit COLLABORATOR_GUIDE.md on closing issues by Trott · Pull Request #24477 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues and pull requests, etc.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
doc: edit COLLABORATOR_GUIDE.md on closing issues
747a030 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2018

Copy link
Copy Markdown
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 19, 2018
@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1654/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sagirk
sagirk approved these changes Nov 19, 2018
View reviewed changes

@sagirk sagirk left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
starkwang
starkwang approved these changes Nov 19, 2018
View reviewed changes
addaleax
addaleax approved these changes Nov 19, 2018
View reviewed changes
jasnell
jasnell reviewed Nov 19, 2018
View reviewed changes
Comment thread COLLABORATOR_GUIDE.md
future of the Node.js project. Where this is unclear, leave the issue or pull
request open for several days to allow for discussion. Where this does not yield
evidence that the issue or pull request has relevance, close it. Remember that
issues and pull requests can always be re-opened if necessary.

@jasnell jasnell Nov 19, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should say something about the use of the stalled label in here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mhdawson
mhdawson approved these changes Nov 19, 2018
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjihrig
cjihrig approved these changes Nov 19, 2018
View reviewed changes
fhinkel
fhinkel approved these changes Nov 20, 2018
View reviewed changes
lpinca
lpinca approved these changes Nov 20, 2018
View reviewed changes
@Trott

Trott commented Nov 21, 2018

Copy link
Copy Markdown
Member Author

Landed in 0759b57
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 21, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2018
@Trott
doc: edit COLLABORATOR_GUIDE.md on closing issues
0759b57 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: nodejs#24477
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 21, 2018
@Trott @targos
doc: edit COLLABORATOR_GUIDE.md on closing issues
4b786aa 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: #24477
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: edit COLLABORATOR_GUIDE.md on closing issues
672a31c 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: #24477
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@Trott @codebytere
doc: edit COLLABORATOR_GUIDE.md on closing issues
c91228c 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: #24477
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
doc: edit COLLABORATOR_GUIDE.md on closing issues
606cb7c 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: nodejs#24477
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
doc: edit COLLABORATOR_GUIDE.md on closing issues
b1bbedd 
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: #24477
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258
Closed
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262
Closed
@Trott
Trott deleted the closing branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
+4 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@sagirk sagirk sagirk approved these changes
@mhdawson mhdawson mhdawson approved these changes
@starkwang starkwang starkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@Trott @nodejs-github-bot @fhinkel @jasnell @addaleax @lpinca @cjihrig @sagirk @mhdawson @starkwang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.