GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: replace create new Array by koh110 · Pull Request #24618 · nodejs/node

Conversation

@koh110

@koh110 koh110 commented Nov 24, 2018

Copy link
Copy Markdown
Contributor
Checklist

replace Array::New(size) to new API on v8.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@koh110
src: replace create new Array
30afb5b
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 24, 2018
addaleax
addaleax approved these changes Nov 24, 2018
View reviewed changes
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@hiroppy hiroppy added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 24, 2018
Leko
Leko approved these changes Nov 24, 2018
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Nov 25, 2018
View reviewed changes
devsnek
devsnek approved these changes Nov 25, 2018
View reviewed changes
@gireeshpunathil

gireeshpunathil commented Nov 25, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18950/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shisama
shisama approved these changes Nov 28, 2018
View reviewed changes
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/19015/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil

gireeshpunathil commented Nov 29, 2018

Copy link
Copy Markdown
Member

landed as 1dfa1a2 , thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil closed this Nov 29, 2018
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Nov 29, 2018
@koh110 @gireeshpunathil
src: replace create new Array
1dfa1a2 
PR-URL: nodejs#24618
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
targos pushed a commit that referenced this pull request Nov 29, 2018
@koh110 @targos
src: replace create new Array
b554ff7 
PR-URL: #24618
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@koh110
koh110 deleted the v8_depricate_serdes branch November 30, 2018 07:52
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@koh110 @refack
src: replace create new Array
fc6c372 
PR-URL: nodejs#24618
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@BethGriggs BethGriggs added the dont-land-on-v10.x label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
@Leko Leko Leko approved these changes
@devsnek devsnek devsnek approved these changes
@shisama shisama shisama approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@koh110 @gireeshpunathil @Trott @addaleax @Leko @devsnek @shisama @hiroppy @BethGriggs @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.