GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: fix comment nits in bootstrap\loaders.js by vsemozhetbyt · Pull Request #24641 · nodejs/node

Conversation

@vsemozhetbyt

@vsemozhetbyt vsemozhetbyt commented Nov 25, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vsemozhetbyt
lib: fix comment nits in bootstrap\loaders.js
754f1cb
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2018

Copy link
Copy Markdown
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1700/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt added the lib / src Issues and PRs involving general changes in the lib/ or src/ directories. label Nov 25, 2018
@vsemozhetbyt

vsemozhetbyt commented Nov 25, 2018

Copy link
Copy Markdown
Contributor Author

As only comments are changed, it seems CI-lite suffices. Let me know if we need full CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt

vsemozhetbyt commented Nov 25, 2018

Copy link
Copy Markdown
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 26, 2018
View reviewed changes
fhinkel
fhinkel approved these changes Nov 27, 2018
View reviewed changes
@vsemozhetbyt

vsemozhetbyt commented Nov 27, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 1db808c
Thank you for the reviews.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt closed this Nov 27, 2018
@vsemozhetbyt
vsemozhetbyt deleted the lib-internal-bootstrap-loaders.js branch November 27, 2018 14:16
vsemozhetbyt added a commit that referenced this pull request Nov 27, 2018
@vsemozhetbyt
lib: fix comment nits in bootstrap\loaders.js
1db808c 
PR-URL: #24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2018
@vsemozhetbyt @targos
lib: fix comment nits in bootstrap\loaders.js
90f423d 
PR-URL: #24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@vsemozhetbyt @rvagg
lib: fix comment nits in bootstrap\loaders.js
1063e0c 
PR-URL: #24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@vsemozhetbyt @refack
lib: fix comment nits in bootstrap\loaders.js
8463833 
PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs added the backport-requested-v10.x label Mar 14, 2019
@GaryGSC GaryGSC mentioned this pull request Nov 8, 2019
[v10.x backport] lib: fix comment nits in bootstrap\loaders.js #30338
Closed
2 tasks done
GaryGSC pushed a commit to GaryGSC/node that referenced this pull request Nov 8, 2019
@vsemozhetbyt @GaryGSC
lib: fix comment nits in bootstrap\loaders.js
e37212f 
Backport-PR-URL: nodejs#30338

PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

(cherry picked from commit 1db808c)
BethGriggs pushed a commit that referenced this pull request Nov 22, 2019
@vsemozhetbyt @BethGriggs
lib: fix comment nits in bootstrap\loaders.js
efeac48 
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
v10.18.1 proposal #30796
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@vsemozhetbyt @MylesBorins
lib: fix comment nits in bootstrap\loaders.js
81c3100 
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
v10.18.1 proposal #31248
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+1 more reviewer
@fhinkel fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vsemozhetbyt @nodejs-github-bot @fhinkel @lpinca @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.