GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: describe current HTTP header size limit by sam-github · Pull Request #24700 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lirantal reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2018

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1708/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. errors Issues and PRs related to JavaScript errors originating in Node.js core. labels Nov 28, 2018
@sam-github

sam-github commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

This does not replace #24693, it fixes the existing reference to 80KB in errors.md, but doesn't touch the HTTP docs themselves. It was intended that this be part of 1860352 but it got missed, sorry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Nov 28, 2018
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sam-github
doc: describe current HTTP header size limit
19cdee8 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693
@sam-github
sam-github force-pushed the doc-8kb-http-header-limit branch from bfb4d4a to 19cdee8 Compare November 28, 2018 18:12
vsemozhetbyt
vsemozhetbyt reviewed Nov 28, 2018
View reviewed changes
Comment thread doc/api/errors.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt
vsemozhetbyt approved these changes Nov 28, 2018
View reviewed changes
@vsemozhetbyt vsemozhetbyt added http Issues and PRs related to the http subsystem. http_parser Issues and PRs related to the HTTP parser implementation or http_parser binding. labels Nov 28, 2018
@vsemozhetbyt @sam-github
fixup
bb3d672 
Co-Authored-By: sam-github <[email protected]>
@sam-github

sam-github commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

sorry, misunderstood format of description field
vsemozhetbyt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt

vsemozhetbyt commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
vsemozhetbyt and Trott reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt

vsemozhetbyt commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1711/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 28, 2018
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 28, 2018
@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Landed in 063e8fb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@sam-github @Trott
doc: describe current HTTP header size limit
063e8fb 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@sam-github
sam-github deleted the doc-8kb-http-header-limit branch November 28, 2018 21:59
targos pushed a commit that referenced this pull request Nov 29, 2018
@sam-github @targos
doc: describe current HTTP header size limit
68dc100 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@sam-github @MylesBorins
doc: describe current HTTP header size limit
f30d169 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@MylesBorins MylesBorins added the dont-land-on-v8.x label Dec 25, 2018
@MylesBorins MylesBorins added the land-on-v10.x label Dec 25, 2018
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@sam-github @MylesBorins
doc: describe current HTTP header size limit
e669733 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
v10.15.0 proposal #25176
Merged
This was referenced Dec 26, 2018
2018-12-26 Version 10.15.0 'Dubnium' (LTS) @MylesBorins beevelop/docker-nodejs#254
Closed
2018-12-26 Version 10.15.0 'Dubnium' (LTS) @MylesBorins beevelop/docker-android-nodejs#276
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sam-github @refack
doc: describe current HTTP header size limit
f045f1b 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
+1 more reviewer
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. errors Issues and PRs related to JavaScript errors originating in Node.js core. fast-track PRs proposed for a shorter-than-standard waiting period before landing. http_parser Issues and PRs related to the HTTP parser implementation or http_parser binding. http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing API docs for recent changes in HTTP module

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sam-github @nodejs-github-bot @vsemozhetbyt @Trott @mcollina @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.