GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: use custom TryCatch subclass by devsnek · Pull Request #24751 · nodejs/node

Conversation

@devsnek

@devsnek devsnek commented Nov 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

pulled out of #23926

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@devsnek
devsnek requested review from addaleax and joyeecheung November 30, 2018 14:14
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1745/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Nov 30, 2018
@devsnek devsnek added the errors Issues and PRs related to JavaScript errors originating in Node.js core. label Nov 30, 2018
@devsnek
devsnek force-pushed the refactor/native-try-catch branch from 455b2e1 to f005e34 Compare November 30, 2018 14:23
joyeecheung
joyeecheung approved these changes Nov 30, 2018
View reviewed changes
@joyeecheung

joyeecheung commented Nov 30, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19087/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
devsnek force-pushed the refactor/native-try-catch branch from f005e34 to 39c9a18 Compare December 3, 2018 15:15
@devsnek

devsnek commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/19152/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
src: use custom TryCatch subclass
f084e06 
PR-URL: nodejs#24751
Reviewed-By: Joyee Cheung <[email protected]>
@devsnek
devsnek force-pushed the refactor/native-try-catch branch from 39c9a18 to f084e06 Compare December 3, 2018 16:25
@devsnek

devsnek commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

landed in f084e06
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
devsnek merged commit f084e06 into nodejs:master Dec 3, 2018
@Trott

Trott commented Dec 3, 2018

Copy link
Copy Markdown
Member

This is getting-the-word-out and not a complaint/criticism, as the rule changed less than two months ago and not everyone has gotten the memo yet:

This should not have landed without a second review or waiting until it had been open 7 days. https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#code-reviews:

At least two Collaborators must approve a pull request before the pull request lands. (One Collaborator approval is enough if the pull request has been open for more than 7 days.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
devsnek deleted the refactor/native-try-catch branch December 3, 2018 18:47
@devsnek

devsnek commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

@Trott thanks, i'll remember that in the future 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Dec 3, 2018

Copy link
Copy Markdown
Member

Should be fixed by nodejs/node-core-utils#290 (I just updated the branch), anyone wants to take a look?

screen shot 2018-12-04 at 2 48 56 am
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@devsnek @BridgeAR
src: use custom TryCatch subclass
c957adb 
PR-URL: #24751
Reviewed-By: Joyee Cheung <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@devsnek @refack
src: use custom TryCatch subclass
82c5176 
PR-URL: nodejs#24751
Reviewed-By: Joyee Cheung <[email protected]>
@BethGriggs

BethGriggs commented Feb 12, 2019

Copy link
Copy Markdown
Member

This change does not land cleanly on v10.x-staging. I've added the backport-requested-v10.x label, but feel free to swap to dont-land-on- if this change shouldn't land on v10.x.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BethGriggs BethGriggs added the backport-requested-v10.x label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originating in Node.js core. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@devsnek @nodejs-github-bot @joyeecheung @Trott @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.