GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: minor cleanup by BridgeAR · Pull Request #25149 · nodejs/node

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Dec 20, 2018

Copy link
Copy Markdown
Member

Just two minor things I stumbled upon while looking at other things.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
addaleax
addaleax approved these changes Dec 20, 2018
View reviewed changes
Comment thread lib/util.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Dec 20, 2018
View reviewed changes
@BridgeAR
BridgeAR force-pushed the remove-obsolete-call branch from 2c91690 to 3ceea0a Compare December 23, 2018 17:13
@BridgeAR

BridgeAR commented Dec 23, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

PTAL

I moved the types part into the bootstrapping part. That seemed like the most natural place for it.

CI https://ci.nodejs.org/job/node-test-pull-request/19761/
CI https://ci.nodejs.org/job/node-test-pull-request/19762/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 23, 2018
BridgeAR added 2 commits December 23, 2018 18:16
@BridgeAR
bootstrap: make sure all type checks exist early
21c0a0e 
Combine all type checks on the internal types binding during
bootstrapping. This makes sure all of those checks exist early on
and not only after loading the util module.
@BridgeAR
console: use spread notation instead of Object.assign
8c06fd3
@BridgeAR
BridgeAR force-pushed the remove-obsolete-call branch from 3ceea0a to 8c06fd3 Compare December 23, 2018 17:16
@Trott

Trott commented Dec 23, 2018

Copy link
Copy Markdown
Member

CI failures are sufficiently extensive that I'm going to remove the author ready label. Feel free to re-add it as soon as appropriate. Not objecting. Just keeping it out of my search results until it's actually ready. :-D
BridgeAR reacted with thumbs up emoji BridgeAR reacted with laugh emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 23, 2018
@BridgeAR
fixup
8f56213
@BridgeAR

BridgeAR commented Dec 23, 2018 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/19770/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devsnek
devsnek reviewed Dec 23, 2018
View reviewed changes
Comment thread lib/internal/bootstrap/node.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR
fixup: refactor internal types
394bfb9 
Now all type checks should be required loading 'internal/util/types'.
@Trott

Trott commented Dec 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Post fixup commit CI: https://ci.nodejs.org/job/node-test-pull-request/19777/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Dec 27, 2018

Copy link
Copy Markdown
Member Author

@lpinca @addaleax @devsnek PTAL (I changed the code significantly enough that confirming the LG would be good).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Dec 27, 2018

Copy link
Copy Markdown
Member

Still LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 27, 2018
jasnell
jasnell approved these changes Dec 27, 2018
View reviewed changes
lundibundi
lundibundi approved these changes Dec 27, 2018
View reviewed changes
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 27, 2018
@BridgeAR
lib: expose all type checks from the internal types module
5ac30c9 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 27, 2018
@BridgeAR
console: use spread notation instead of Object.assign
4ea2c1c 
PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR

BridgeAR commented Dec 27, 2018

Copy link
Copy Markdown
Member Author

Landed in 5ac30c9 and 4ea2c1c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Dec 27, 2018
targos pushed a commit that referenced this pull request Jan 1, 2019
@BridgeAR @targos
console: use spread notation instead of Object.assign
561c268 
PR-URL: #25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@addaleax addaleax added the backport-requested-v11.x label Jan 5, 2019
@addaleax

addaleax commented Jan 5, 2019

Copy link
Copy Markdown
Member

The lib: commit does not apply cleanly, so:

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 9, 2019
@BridgeAR
lib: expose all type checks from the internal types module
4788625 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 9, 2019
[v11.x] backport of #25105, #25149 and #25150 #25406
Closed
4 tasks done
BridgeAR added a commit that referenced this pull request Jan 10, 2019
@BridgeAR
lib: expose all type checks from the internal types module
e97acf7 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: #25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 10, 2019
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@BridgeAR @joyeecheung
lib: expose all type checks from the internal types module
7d90f03 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
lib: expose all type checks from the internal types module
6528ce6 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: #25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

Backport-PR-URL: #25446
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
lib: expose all type checks from the internal types module
476c4ef 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
console: use spread notation instead of Object.assign
fcd2523 
PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
v11.7.0 proposal #25537
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
lib: expose all type checks from the internal types module
27b8585 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

Backport-PR-URL: nodejs#25446
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
v11.8.0 proposal #25687
Merged
@BridgeAR
BridgeAR deleted the remove-obsolete-call branch January 20, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
+2 more reviewers
@devsnek devsnek devsnek left review comments
@lundibundi lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@BridgeAR @Trott @lpinca @addaleax @jasnell @devsnek @lundibundi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.