GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — process: move process.features initialization into node.js by joyeecheung · Pull Request #25239 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Dec 27, 2018

Copy link
Copy Markdown
Member

Use internalBinding('config') to shim the legacy
process.features.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2077/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 27, 2018
@joyeecheung
joyeecheung force-pushed the port-features branch from 277a2ea to a7f3f89 Compare December 27, 2018 13:54
@joyeecheung
process: move process.features initialization into node.js
bc1ceb8 
Use `internalBinding('config')` to shim the legacy
`process.features`.
@joyeecheung
joyeecheung force-pushed the port-features branch from a7f3f89 to bc1ceb8 Compare December 27, 2018 13:56
joyeecheung
joyeecheung commented Dec 27, 2018
View reviewed changes
Comment thread lib/internal/bootstrap/node.js
debug: isDebugBuild,
uv: true,
ipv6: true, // TODO(bnoordhuis) ping libuv
tls_alpn: hasOpenSSL,

@joyeecheung joyeecheung Dec 27, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be available as process.versions.openssl even though that's not the purpose of that property - I wonder if we should just use that instead?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung

joyeecheung commented Dec 27, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19830/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Dec 27, 2018
View reviewed changes
@addaleax

addaleax commented Dec 27, 2018 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19835/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added process Issues and PRs related to the process subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 27, 2018
jasnell
jasnell approved these changes Dec 27, 2018
View reviewed changes
JungMinu
JungMinu approved these changes Dec 28, 2018
View reviewed changes
@addaleax

addaleax commented Dec 31, 2018

Copy link
Copy Markdown
Member

Landed in 39a2ac4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Dec 31, 2018
addaleax pushed a commit that referenced this pull request Dec 31, 2018
@joyeecheung @addaleax
process: move process.features initialization into node.js
39a2ac4 
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: #25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Jan 4, 2019
process.features: deprecate it or add more properties? #25343
Closed
@addaleax addaleax added the backport-requested-v11.x label Jan 5, 2019
@addaleax

addaleax commented Jan 5, 2019

Copy link
Copy Markdown
Member

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
process: move process.features initialization into node.js
aefe479 
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@addaleax

addaleax commented Jan 15, 2019

Copy link
Copy Markdown
Member

This applies cleanly now :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Jan 15, 2019
@joyeecheung @addaleax
process: move process.features initialization into node.js
2bd7437 
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: #25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@addaleax addaleax removed the backport-requested-v11.x label Jan 15, 2019
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
v11.7.0 proposal #25537
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@joyeecheung @BridgeAR
process: move process.features initialization into node.js
aa186d1 
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
@joyeecheung @BridgeAR
process: move process.features initialization into node.js
743056e 
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
v11.8.0 proposal #25687
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@JungMinu JungMinu JungMinu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@joyeecheung @nodejs-github-bot @addaleax @jasnell @JungMinu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.