GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [v11.x] deps: cherry-pick d9fbfeb from upstream V8 by kjin · Pull Request #25331 · nodejs/node

Conversation

kjin commented Jan 3, 2019

Copy link

Copy Markdown

Contributor

Original commit message:

inspector: return [[StableObjectId]] as internal property

This property might be useful for fast '===' check.

[email protected],[email protected]

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56095}

See: #23886

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          deps: cherry-pick d9fbfeb from upstream V8

7c087b1

Original commit message:

	inspector: return [[StableObjectId]] as internal property

	This property might be useful for fast '===' check.

	[email protected],[email protected]

	Bug: none
	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
	Reviewed-on: https://chromium-review.googlesource.com/1226411
	Reviewed-by: Dmitry Gozman <[email protected]>
	Reviewed-by: Yang Guo <[email protected]>
	Reviewed-by: Jakob Gruber <[email protected]>
	Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
	Cr-Commit-Position: refs/heads/master@{nodejs#56095}

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

v11.x v8 engine Issues and PRs related to the V8 dependency. labels

Jan 3, 2019

bnoordhuis approved these changes

Jan 6, 2019

View reviewed changes

bnoordhuis left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Node.js CI: https://ci.nodejs.org/job/node-test-pull-request/19957/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1986/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bnoordhuis commented Jan 7, 2019

Copy link

Copy Markdown

Member

The test failure is #24005 and not caused by this PR:

14:08:41 not ok 527 parallel/test-worker-cleanup-handles
14:08:41   ---
14:08:41   duration_ms: 120.106
14:08:41   severity: fail
14:08:41   exitcode: 1
14:08:41   stack: |-
14:08:41     timeout
14:08:41   ...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR commented Jan 9, 2019

Copy link

Copy Markdown

Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/20035/
V8 CI https://ci.nodejs.org/job/node-test-commit-v8-linux/1995/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR approved these changes

Jan 9, 2019

View reviewed changes

BridgeAR pushed a commit that referenced this pull request

Jan 9, 2019


          deps: cherry-pick d9fbfeb from upstream V8

e1d4f43

Original commit message:

	inspector: return [[StableObjectId]] as internal property

	This property might be useful for fast '===' check.

	[email protected],[email protected]

	Bug: none
	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
	Reviewed-on: https://chromium-review.googlesource.com/1226411
	Reviewed-by: Dmitry Gozman <[email protected]>
	Reviewed-by: Yang Guo <[email protected]>
	Reviewed-by: Jakob Gruber <[email protected]>
	Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
	Cr-Commit-Position: refs/heads/master@{#56095}

PR-URL: #25331
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

BridgeAR commented Jan 9, 2019

Copy link

Copy Markdown

Member

Landed in e1d4f43 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR closed this

Jan 9, 2019

BridgeAR mentioned this pull request

Jan 16, 2019

v11.7.0 proposal #25537

Merged

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Jan 16, 2019


          deps: cherry-pick d9fbfeb from upstream V8

f0e876f

Original commit message:

	inspector: return [[StableObjectId]] as internal property

	This property might be useful for fast '===' check.

	[email protected],[email protected]

	Bug: none
	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
	Reviewed-on: https://chromium-review.googlesource.com/1226411
	Reviewed-by: Dmitry Gozman <[email protected]>
	Reviewed-by: Yang Guo <[email protected]>
	Reviewed-by: Jakob Gruber <[email protected]>
	Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
	Cr-Commit-Position: refs/heads/master@{nodejs#56095}

PR-URL: nodejs#25331
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

MylesBorins mentioned this pull request

Jan 24, 2019

v11.8.0 proposal #25687

Merged

Reviewers

bnoordhuis

bnoordhuis approved these changes

BridgeAR

BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.