GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Refactor mac installer (Rebase of #776 against master) by fhemberger · Pull Request #2571 · nodejs/node

Conversation

fhemberger commented Aug 27, 2015

Copy link

Copy Markdown

Contributor

Can you please check, if the Mac installer is built and working correctly?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

fhemberger mentioned this pull request

Aug 27, 2015

Refactor Mac installer generation #776

Closed

brendanashworth added install

Issues and PRs related to installing Node.js and its installers.

macos Issues and PRs related to the macOS platform. labels

Aug 27, 2015

pmq20 commented Aug 27, 2015

Copy link

Copy Markdown

Contributor

Given that tools/osx-pkg.pmdoc/index.xml.tmpl has been deleted, why Makefile still has a line [1] read cat tools/osx-pkg.pmdoc/index.xml.tmpl?

[1] https://github.com/fhemberger/node/blob/refactor-mac-installer-rebase/Makefile#L351

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Aug 27, 2015

Copy link

Copy Markdown

Contributor Author

Because I forgot to remove it. ;) Good catch, thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

remixz reviewed

Aug 27, 2015

View reviewed changes

Comment thread

Makefile Outdated

remixz Aug 27, 2015

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed to touch tools/osx-pkg/scripts/nodejs-run-uninstall

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

With the couple of changes I noted on the files, this builds! 🎉 This is great, cheers to you @fhemberger. I had tried to rebase it a little while ago, but I unfortunately didn't get far. I'm very glad you did. 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Aug 28, 2015

Copy link

Copy Markdown

Contributor Author

@remixz Phew, I'm glad it worked out. Thanks for your help!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fishrock123 commented Aug 28, 2015

Copy link

Copy Markdown

Contributor

Linking: #776

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rvagg force-pushed the master branch from 11c25c2 to ba02bd0 Compare

September 6, 2015 11:55

silverwind commented Sep 8, 2015

Copy link

Copy Markdown

Contributor

Very minor issue with the current installer: The logo is not scaled properly and is telling me 'No' :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Sep 8, 2015

Copy link

Copy Markdown

Contributor Author

For the sidebar, I think we should go with a colored version oft the hexagon, instead of scaling the logo down. What do you think?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

silverwind commented Sep 8, 2015

Copy link

Copy Markdown

Contributor

👍 would make better use of the available space than the scaled logo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Sep 9, 2015

Copy link

Copy Markdown

Contributor Author

Can someone please confirm that the rebased version is building correctly?
Also updated the installer logo:

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Sep 20, 2015

Copy link

Copy Markdown

Contributor Author

@nodejs/build Can we please merge this? Various incarnations of this PR have been open for months now, and I'd like to get this done, so we can start with the actual translation work (same for the Windows installer).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rvagg commented Sep 21, 2015

Copy link

Copy Markdown

Member

yes, but no, needs changes on the build machines so requires some additional work and testing, non-trivial merge, I'm sorry that I'm currently holding this one up, I'll (a) be trying to get to this as soon as I can and (b) removing myself as a bottleneck as we get more of the build team access to the osx machines

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Oct 14, 2015

Copy link

Copy Markdown

Contributor Author

< insert (almost) monthly nag here > 😄

As v5 seems to be already waiting around the corner, it would be great if this could land as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell commented Oct 14, 2015

Copy link

Copy Markdown

Member

Does this supersede / replace #776?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

silverwind commented Oct 14, 2015

Copy link

Copy Markdown

Contributor

@fhemberger can you provide some build instructions for the installer, so I can test it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Oct 15, 2015

Copy link

Copy Markdown

Contributor Author

@jasnell Yes, it's the changes of #776 rebased against the current master.

@silverwind Install Packages, then build for OS X:

./configure
make
make pre-pkg
make install DESTDIR=out/dist-osx
/usr/local/bin/packagesbuild tools/osx-pkg/osx-pkg-out.pkgproj

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

silverwind commented Oct 15, 2015

Copy link

Copy Markdown

Contributor

Gave it a few installs/uninstalls and it looks to be working great. Only nag I have is that it says 'Node.js was installed' after uninstalling. Other than that, LGTM.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rvagg added this to the 5.0.0 milestone

Oct 16, 2015

rvagg mentioned this pull request

Oct 16, 2015

v5.0.0 Planning & Checklist #3397

Closed

13 tasks done

evanlucas commented Oct 22, 2015

Copy link

Copy Markdown

Contributor

The current packages are named node-vx.x.x.pkg. This changes that to nodejs-vx.x.x.pkg. I would think that could break some external tools maybe?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

silverwind commented Oct 22, 2015

Copy link

Copy Markdown

Contributor

Should be the node scheme: https://nodejs.org/dist/v4.2.1/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhemberger commented Oct 23, 2015

Copy link

Copy Markdown

Contributor Author

@evanlucas Good catch, fixed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

evanlucas reviewed

Oct 23, 2015

View reviewed changes

Comment thread

tools/osx-pkg/scripts/uninstall.sh Outdated

evanlucas Oct 23, 2015

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if it was installed to a custom location?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

fhemberger Oct 23, 2015

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't choose a custom location in the installer.

Sorry, the screenshot is German but you get the idea.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

evanlucas Oct 23, 2015

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good point

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

evanlucas commented Oct 23, 2015

Copy link

Copy Markdown

Contributor

Do we have a retina image available for the sidebar? I wonder if packages even supports that. If so, we should probably add that.

This seems to work well. @rvagg if there is anything I can do to help on the build side of things to get this in for v5.0.0, feel free to let me know :] Overall, LGTM for whenever this can land.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jbergstroem commented Oct 23, 2015

Copy link

Copy Markdown

Member

@evanlucas mac installers surely must be able to render a svg, no?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jpwesselink added a commit to jpwesselink/node that referenced this pull request

Sep 15, 2017


          tools, build: macOS installer

bf9157f

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm

PR-URL: nodejs#15179
Fixes: nodejs#15012
Refs: nodejs#5656
Refs: nodejs#2571
Refs: nodejs#7097

BridgeAR pushed a commit that referenced this pull request

Sep 28, 2017


          tools, build: refactor macOS installer

03954f7

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Sep 29, 2017


          tools, build: refactor macOS installer

803d9c1

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Sep 30, 2017


          tools, build: refactor macOS installer

29a3b3a

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: nodejs/node#15179
Fixes: nodejs/node#15012
Refs: nodejs/node#5656
Refs: nodejs/node#2571
Refs: nodejs/node#7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Oct 3, 2017


          tools, build: refactor macOS installer

7e8c0fd

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Oct 3, 2017


          tools, build: refactor macOS installer

eebb2d7

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Jan 16, 2018


          tools, build: refactor macOS installer

2400fc2

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Jan 17, 2018


          tools, build: refactor macOS installer

23ad5cb

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Feb 11, 2018


          tools, build: refactor macOS installer

7bab6bc

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Feb 12, 2018


          tools, build: refactor macOS installer

3a12b46

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Feb 13, 2018


          tools, build: refactor macOS installer

18803bc

Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

solebox mentioned this pull request

Nov 27, 2023

[Snyk] Fix for 3 vulnerabilities solebox/node#33

Open

s4sc mentioned this pull request

Nov 28, 2023

[Snyk] Fix for 3 vulnerabilities s4sc/node#32

Open

enterstudio mentioned this pull request

Nov 29, 2023

[Snyk] Fix for 3 vulnerabilities enterstudio/node#32

Open

This was referenced Mar 29, 2024

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1273

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1274

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1275

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1276

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1277

Open

This was referenced Mar 30, 2024

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 leonardoadame/node#702

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 leonardoadame/node#703

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 leonardoadame/node#704

Open

This was referenced Mar 30, 2024

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1279

Open

[Snyk] Security upgrade gulp from 3.9.1 to 5.0.0 aliscco/alisco-node#1280

Open

snyk-io Bot mentioned this pull request

Oct 21, 2024

[Snyk] Fix for 26 vulnerabilities Graybar-codespace/node#49

Open

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

install

Issues and PRs related to installing Node.js and its installers.

macos

Issues and PRs related to the macOS platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

fhemberger commented Aug 27, 2015

Uh oh!

pmq20 commented Aug 27, 2015

Uh oh!

fhemberger commented Aug 27, 2015

Uh oh!

remixz Aug 27, 2015

Choose a reason for hiding this comment

Uh oh!

remixz commented Aug 27, 2015

Uh oh!

fhemberger commented Aug 28, 2015

Uh oh!

Fishrock123 commented Aug 28, 2015

Uh oh!

silverwind commented Sep 8, 2015

Uh oh!

fhemberger commented Sep 8, 2015

Uh oh!

silverwind commented Sep 8, 2015

Uh oh!

fhemberger commented Sep 9, 2015

Uh oh!

fhemberger commented Sep 20, 2015

Uh oh!

rvagg commented Sep 21, 2015

Uh oh!

fhemberger commented Oct 14, 2015

Uh oh!

jasnell commented Oct 14, 2015

Uh oh!

silverwind commented Oct 14, 2015

Uh oh!

fhemberger commented Oct 15, 2015

Uh oh!

silverwind commented Oct 15, 2015

Uh oh!

evanlucas commented Oct 22, 2015

Uh oh!

silverwind commented Oct 22, 2015

Uh oh!

fhemberger commented Oct 23, 2015

Uh oh!

evanlucas Oct 23, 2015

Choose a reason for hiding this comment

Uh oh!

fhemberger Oct 23, 2015

Choose a reason for hiding this comment

Uh oh!

evanlucas Oct 23, 2015

Choose a reason for hiding this comment

Uh oh!

evanlucas commented Oct 23, 2015

Uh oh!

jbergstroem commented Oct 23, 2015

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants