GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [v8.x] deps: V8: cherry-pick 3cc6919 by miladfarca · Pull Request #25874 · nodejs/node

Conversation

miladfarca commented Feb 1, 2019

Copy link

Copy Markdown

Contributor

Original commit message:

PPC: fix Regex addi overflow

using add insetad of addi when Operand is more than 16 bits long

Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
Reviewed-on: https://chromium-review.googlesource.com/c/1430619
Commit-Queue: Junliang Yan <[email protected]>
Reviewed-by: Junliang Yan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#59049}

Refs: v8/v8@3cc6919

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot added v8 engine

Issues and PRs related to the V8 dependency.

v8.x labels

Feb 1, 2019

miladfarca commented Feb 1, 2019

Copy link

Copy Markdown

Contributor Author

V8 version on master already includes this fix, backporting it to v8.x. A separate PR has been created for backporting it to v10.x: #25872

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau approved these changes

Feb 1, 2019

View reviewed changes

mhdawson approved these changes

Feb 1, 2019

View reviewed changes

mhdawson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson commented Feb 1, 2019

Copy link

Copy Markdown

Member

V8 CI run: https://ci.nodejs.org/job/node-test-commit-v8-linux/2065/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau changed the title ~~deps: V8: cherry-pick 3cc6919~~ [v8.x] deps: V8: cherry-pick 3cc6919

Feb 1, 2019

gdams approved these changes

Feb 2, 2019

View reviewed changes

BethGriggs approved these changes

Feb 5, 2019

View reviewed changes

rvagg force-pushed the v8.x-staging branch from 03e2a82 to d4b6643 Compare

February 28, 2019 12:40


          deps: V8: cherry-pick 3cc6919

547c515

Original commit message:

    PPC: fix Regex addi overflow

    using add insetad of addi when Operand is more than 16 bits long

    Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
    Reviewed-on: https://chromium-review.googlesource.com/c/1430619
    Commit-Queue: Junliang Yan <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#59049}

Refs: v8/v8@3cc6919

BethGriggs pushed a commit that referenced this pull request

Mar 21, 2019


          deps: V8: cherry-pick 3cc6919

97cc0fc

Original commit message:

    PPC: fix Regex addi overflow

    using add insetad of addi when Operand is more than 16 bits long

    Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
    Reviewed-on: https://chromium-review.googlesource.com/c/1430619
    Commit-Queue: Junliang Yan <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#59049}

Refs: v8/v8@3cc6919

PR-URL: #25874
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>

BethGriggs commented Mar 21, 2019

Copy link

Copy Markdown

Member

Landed on v8.x-staging

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs closed this

Mar 21, 2019

MylesBorins mentioned this pull request

Mar 26, 2019

v8.16.0 proposal #26933

Merged

snyk-bot mentioned this pull request

Aug 11, 2020

[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark radiumrasheed/node#4

Open

Reviewers

richardlau

richardlau approved these changes

BethGriggs

BethGriggs approved these changes

+2 more reviewers

mhdawson

mhdawson approved these changes

gdams

gdams approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.