GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — deps: update V8 to 7.6 by ryzokuken · Pull Request #28016 · nodejs/node Conversation
Contributor
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
targos
force-pushed
the
v8-7.6
branch
2 times, most recently
from
28704ed to
fe8bf54
Compare
|
There was an error while loading. Please reload this page.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23554/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cjihrig Along with 9106789 (which I had to do to make it compile), we have some missing constants: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@nodejs/platform-ppc @nodejs/platform-s390 we have some segfaults in V8 tests: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=ppcle-ubuntu1404,v8test=v8test/ https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=rhel72-s390x,v8test=v8test/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sure thing. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
It get's that way from time to time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@refack the flaky test? might be an undefined behaviour where it passes or fails form time to time (due to this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1561072), will be looking into it using V8 master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ryzokuken / @targos can you try cherry-picking in cjihrig@19d7b31 and cjihrig@9e50c0a. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cjihrig @targos @refack fixed and done! PTAL. Making this PR ready for review. 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Update postmortem metadata constants for V8 7.6 in Node.js. PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Update postmortem metadata constants for V8 7.6 in Node.js. PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Update postmortem metadata constants for V8 7.6 in Node.js. PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.