GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 7.6 by ryzokuken · Pull Request #28016 · nodejs/node

Conversation

@ryzokuken

@ryzokuken ryzokuken commented Jun 2, 2019

Copy link
Copy Markdown
Contributor

🎉
Thanks @targos @refack

@cjihrig could you PTAL at 9106789138?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, gengjiawen, lin7sh, eug48, tlhunter, ulrichb, and motss reacted with thumbs up emoji refack, bricss, BridgeAR, lin7sh, ulrichb, and motss reacted with heart emoji bricss, gengjiawen, lin7sh, and motss reacted with rocket emoji
All reactions
  • 👍 7 reactions
  • ❤️ 6 reactions
  • 🚀 4 reactions
@ryzokuken
ryzokuken requested review from refack and targos June 2, 2019 10:24
@ryzokuken

ryzokuken commented Jun 2, 2019

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/v8-update

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos
targos force-pushed the v8-7.6 branch 2 times, most recently from 28704ed to fe8bf54 Compare June 2, 2019 11:28
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2019 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23554/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

This comment has been minimized.

Sign in to view
@targos

targos commented Jun 2, 2019

Copy link
Copy Markdown
Member

@cjihrig Along with 9106789 (which I had to do to make it compile), we have some missing constants: v8dbg_class_FixedTypedArrayBase__base_pointer__Object,v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t,v8dbg_class_Map__instance_descriptors_offset

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Jun 2, 2019

Copy link
Copy Markdown
Member

@nodejs/platform-ppc @nodejs/platform-s390 we have some segfaults in V8 tests: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=ppcle-ubuntu1404,v8test=v8test/ https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=rhel72-s390x,v8test=v8test/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@refack

This comment has been minimized.

Sign in to view
@miladfarca

miladfarca commented Jun 2, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

s390 and ppc are segfaulting on some tests because of this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1632235, we have a solution but waiting on the original owner to get back to us on a question first.

targos and refack reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jun 2, 2019
@targos

This comment has been minimized.

Sign in to view
@cjihrig

cjihrig commented Jun 2, 2019

Copy link
Copy Markdown
Contributor

@cjihrig could you PTAL at 9106789?

Sure thing.

ryzokuken reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@refack

refack commented Jun 2, 2019

Copy link
Copy Markdown
Contributor

😱 what happened to aix??

It get's that way from time to time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs nodejs deleted a comment from nodejs-github-bot Jun 2, 2019
@refack

This comment has been minimized.

Sign in to view
@miladfarca

miladfarca commented Jun 2, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@refack the flaky test? might be an undefined behaviour where it passes or fails form time to time (due to this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1561072), will be looking into it using V8 master.

refack reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cjihrig

cjihrig commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

@ryzokuken / @targos can you try cherry-picking in cjihrig@19d7b31 and cjihrig@9e50c0a.

refack reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ryzokuken
ryzokuken force-pushed the v8-7.6 branch from 8e8a2c3 to ed3e45d Compare June 3, 2019 15:17
@ryzokuken

ryzokuken commented Jun 3, 2019

Copy link
Copy Markdown
Contributor Author

@cjihrig @targos @refack fixed and done! PTAL. Making this PR ready for review. 🎉

refack, lin7sh, and chicoxyzzy reacted with hooray emoji
All reactions
  • 🎉 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ryzokuken
ryzokuken marked this pull request as ready for review June 3, 2019 15:17
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2019
@cjihrig @nodejs-ci
deps: V8: update postmortem metadata generation script
e8536ce
Update postmortem metadata constants for V8 7.6 in Node.js.

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
f3af584
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
644b7f1
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
ff13269
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@cjihrig @nodejs-ci
deps: V8: update postmortem metadata generation script
6d50bae
Update postmortem metadata constants for V8 7.6 in Node.js.

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
37a49d2
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
7f6a105
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
f79399c
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2019
@cjihrig @nodejs-ci
deps: V8: update postmortem metadata generation script
dd1a8cf
Update postmortem metadata constants for V8 7.6 in Node.js.

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
98add5a
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
v12.9.0 release proposal #29210
Merged
This was referenced Aug 20, 2019
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328
Closed
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329
Closed
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330
Closed
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295
Closed
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296
Closed
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297
Closed
@BethGriggs BethGriggs mentioned this pull request Sep 9, 2019
2019-10-22, Version 13.0.0 (Current) #29504
Merged
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
v12.11.0 proposal #29695
Merged
This was referenced Sep 25, 2019
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#301
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#333
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#302
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#334
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#303
Closed
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#335
Closed
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@targos targos Awaiting requested review from targos
+2 more reviewers
@refack refack refack approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ryzokuken ryzokuken

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@ryzokuken @nodejs-github-bot @targos @refack @miladfarca @cjihrig @ronkorving @richardlau @gengjiawen @Trott @mhdawson @jkunkee
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.