GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: deprecate finished by ronag · Pull Request #28679 · nodejs/node

Conversation

@ronag

@ronag ronag commented Jul 14, 2019

Copy link
Copy Markdown
Member

Remove finished from docs. The naming and function is very confusing and misleading. What is finished is actually ended in the streams spec.

Refs: #28651

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the http Issues and PRs related to the http subsystem. label Jul 14, 2019
@ronag
ronag force-pushed the deprecate-finished branch 4 times, most recently from 11a9c1a to 46e9301 Compare July 14, 2019 12:43
benjamingr
benjamingr reviewed Jul 14, 2019
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be docs-deprecated rather than removed from the docs altogether IMO

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronag
ronag force-pushed the deprecate-finished branch from 46e9301 to d967248 Compare July 14, 2019 14:59
@ronag ronag changed the title http: deprecate finished doc: deprecate finished Jul 14, 2019
@ronag

ronag commented Jul 14, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Not quite sure how to docs-deprecate... but I tried... feedback welcome
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Jul 14, 2019

Copy link
Copy Markdown
Member

Does anyone have a strong opinion regarding how we should deprecate this? @mcollina maybe?

(no hurry)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Jul 14, 2019

Copy link
Copy Markdown
Member

Does anyone have a strong opinion regarding how we should deprecate this?

I agree that documentation-only deprecating makes the most sense here.
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag force-pushed the deprecate-finished branch 2 times, most recently from a97f9fc to cd143ec Compare July 14, 2019 21:19
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Jul 15, 2019
ChALkeR
ChALkeR previously requested changes Jul 31, 2019
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/http2.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag force-pushed the deprecate-finished branch from cd143ec to b62d036 Compare August 1, 2019 18:00
@ronag

ronag commented Aug 2, 2019

Copy link
Copy Markdown
Member Author

Blocked by #28934. Let's see what happens there first. It's relevant to the deprecation description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag mentioned this pull request Aug 5, 2019
http2: make compat finished match http/1 #24347
Closed
4 tasks done
@ronag

ronag commented Aug 5, 2019

Copy link
Copy Markdown
Member Author

fixed @ChALkeR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag force-pushed the deprecate-finished branch from b62d036 to 9d6fbd0 Compare August 5, 2019 09:36
@ronag

ronag commented Aug 5, 2019

Copy link
Copy Markdown
Member Author

@Trott blocked by #28934
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 6, 2019
stream: cleanup #29000
Closed
http: ClientRequest streamlike #29002
Closed
@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Aug 6, 2019
@jasnell jasnell added deprecations Issues and PRs related to deprecations. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 7, 2019
@ronag
ronag force-pushed the deprecate-finished branch 3 times, most recently from aea31b3 to 9a0472a Compare August 17, 2019 07:42
@ronag

ronag commented Aug 17, 2019

Copy link
Copy Markdown
Member Author

@Trott: this is no longer blocked, ping node/http?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag

ronag commented Nov 20, 2019

Copy link
Copy Markdown
Member Author

@Trott: The doc linting error seems unrelated to this PR. Not sure what's going on there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Nov 20, 2019
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
ronag and others added 2 commits November 20, 2019 22:44
@ronag @Trott
Update doc/api/deprecations.md
11337b6 
Co-Authored-By: Rich Trott <[email protected]>
@ronag
fixup: ref
dcd3724
@ronag
ronag force-pushed the deprecate-finished branch from b159660 to dcd3724 Compare November 20, 2019 22:21
@ronag

ronag commented Nov 20, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@Trott: Linting pass
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lundibundi

lundibundi commented Nov 22, 2019

Copy link
Copy Markdown
Member

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4082/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Dec 7, 2019
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
ronag
ronag commented Dec 7, 2019
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag
Update doc/api/deprecations.md
476d612
Trott
Trott approved these changes Dec 7, 2019
View reviewed changes
BridgeAR
BridgeAR reviewed Dec 9, 2019
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag @BridgeAR
Update doc/api/deprecations.md
60c6119 
Co-Authored-By: Ruben Bridgewater <[email protected]>
@BridgeAR

BridgeAR commented Dec 10, 2019

Copy link
Copy Markdown
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4102/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Dec 10, 2019
View reviewed changes
BridgeAR pushed a commit that referenced this pull request Dec 10, 2019
@ronag @BridgeAR
doc: deprecate http finished
c6ab3af 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR

BridgeAR commented Dec 10, 2019

Copy link
Copy Markdown
Member

Landed in c6ab3af 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Dec 10, 2019
targos pushed a commit that referenced this pull request Dec 10, 2019
@ronag @targos
doc: deprecate http finished
93ca4f4 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
MylesBorins added a commit that referenced this pull request Dec 16, 2019
@MylesBorins
2019-12-17, Version 13.4.0 (Current)
57bf5b7 
This is a security release.

This release includes a single commit, an update to npm to 6.13.4.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  - update npm to 6.13.4
    #30904
  - update uvwasi (Anna Henningsen)
    #30745
  - upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  - docs deprecate http finished (Robert Nagy)
    #28679
* events:
  - add captureRejection option (Matteo Collina)
    #27867
* http:
  - add captureRejection support (Matteo Collina)
    #27867
  - llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  - implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  - implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  - support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  - add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  - implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  - expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  - add argv constructor option (legendecas)
    #30559

PR-URL: #30937
MylesBorins added a commit that referenced this pull request Dec 16, 2019
@MylesBorins
2019-12-17, Version 13.4.0 (Current)
906a1fd 
This is a security release.

This release includes a single commit, an update to npm to 6.13.4.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  * update npm to 6.13.4
    #30904
  * update uvwasi (Anna Henningsen)
    #30745
  * upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  * docs deprecate http finished (Robert Nagy)
    #28679
* events:
  * add captureRejection option (Matteo Collina)
    #27867
* http:
  * add captureRejection support (Matteo Collina)
    #27867
  * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  * implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  * implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  * support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  * add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  * implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  * expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  * add argv constructor option (legendecas)
    #30559

PR-URL: #30937
MylesBorins added a commit that referenced this pull request Dec 16, 2019
@MylesBorins
2019-12-17, Version 13.4.0 (Current)
f15fe94 
This is a security release.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  * update npm to 6.13.4
    #30904
  * update uvwasi (Anna Henningsen)
    #30745
  * upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  * docs deprecate http finished (Robert Nagy)
    #28679
* events:
  * add captureRejection option (Matteo Collina)
    #27867
* http:
  * add captureRejection support (Matteo Collina)
    #27867
  * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  * implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  * implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  * support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  * add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  * implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  * expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  * add argv constructor option (legendecas)
    #30559

PR-URL: #30937
MylesBorins added a commit that referenced this pull request Dec 17, 2019
@MylesBorins
2019-12-17, Version 13.4.0 (Current)
bef1e87 
This is a security release.

For more details about the vulnerability please consult the npm blog:

https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Notable Changes:
* deps:
  * update npm to 6.13.4
    #30904
  * update uvwasi (Anna Henningsen)
    #30745
  * upgrade to libuv 1.34.0 (Colin Ihrig)
    #30783
* doc:
  * docs deprecate http finished (Robert Nagy)
    #28679
* events:
  * add captureRejection option (Matteo Collina)
    #27867
* http:
  * add captureRejection support (Matteo Collina)
    #27867
  * llhttp opt-in insecure HTTP header parsing (Sam Roberts)
    #30567
* http2:
  * implement capture rection for 'request' and 'stream' events (Matteo Collina)
    #27867
* net:
  * implement capture rejections for 'connection' event (Matteo Collina)
    #27867
* repl:
  * support previews by eager evaluating input (Ruben Bridgewater)
    #30811
* stream:
  * add support for captureRejection option (Matteo Collina)
    #27867
* tls:
  * implement capture rejections for 'secureConnection' event (Matteo Collina)
    #27867
  * expose IETF name for current cipher suite (Sam Roberts)
    #30637
* worker:
  * add argv constructor option (legendecas)
    #30559

PR-URL: #30937
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag @targos
doc: deprecate http finished
ec514a6 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ronag @BethGriggs
doc: deprecate http finished
79521d3 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeR ChALkeR ChALkeR left review comments
@mcollina mcollina mcollina approved these changes
@Trott Trott Trott approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@addaleax addaleax Awaiting requested review from addaleax
@benjamingr benjamingr Awaiting requested review from benjamingr
+1 more reviewer
@dougwilson dougwilson dougwilson left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. deprecations Issues and PRs related to deprecations. http Issues and PRs related to the http subsystem. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@ronag @benjamingr @addaleax @Trott @nodejs-github-bot @lundibundi @BridgeAR @mcollina @dougwilson @ChALkeR @jasnell @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.