GeezerVison

@dev-313 - if you are planning to attack all of those pending http2 event arguments mentioned in the referenced issue, it may be a good idea to combine the rest into one single PR - easy to review, easy to manage.

Okay @gireeshpunathil . Thanks

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4023/

CI: https://ci.nodejs.org/job/node-test-pull-request/26252/

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@rvagg I think this is related to nodejs/build#2012 (comment).

The Pre-flight stage of https://ci.nodejs.org/job/node-linter/ calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh

sh "curl -L -s https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh -s | bash -xe"

which calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
which tries to write to DIAGFILE=${HOME}/jenkins_diagnostics.txt and fails:

01:40:36  + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
01:40:36  + bash -ex -s before
01:40:36    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
01:40:36                                   Dload  Upload   Total   Spent    Left  Speed
01:40:37  
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   985  100   985    0     0   3315      0 --:--:-- --:--:-- --:--:--  3327
01:40:37  + set +x
01:40:37  bash: line 9: /jenkins_diagnostics.txt: Permission denied

suggesting ${HOME} is empty?

Yes, and I can't work out why $HOME is missing now that we've switched from FreeBSD to Linux for this. There's no special environment variables on the host machine.

I've restored the old FreeBSD servers while we figure this one out. These pipeline builds are the worst for debugging, I've got no idea where HOME has gone to, it's not showing up on an env from the script but there's nothing particularly special about the FreeBSD env compared to the Ubuntu one for that.

Got this sorted out, it was a configuration weirdness specific to the machine that has the most likelihood of being chosen for this task nodejs/build#2021, it's now back off FreeBSD.

landed as 8b53d0b