GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — node_crypto: Don't use deprecated OpenSSL APIs by neheb · Pull Request #30812 · nodejs/node

Conversation

@neheb

@neheb neheb commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 5, 2019
sam-github
sam-github approved these changes Dec 5, 2019
View reviewed changes
jasnell
jasnell approved these changes Dec 5, 2019
View reviewed changes
@neheb

neheb commented Dec 5, 2019

Copy link
Copy Markdown
Contributor Author

No idea what the failures are about.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

Click through the details: https://travis-ci.com/nodejs/node/jobs/263603120
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neheb
src: don't use deprecated OpenSSL APIs
0a8f0e3 
The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 5, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27365/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neheb

neheb commented Dec 5, 2019

Copy link
Copy Markdown
Contributor Author

No idea what the issue is this time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27373/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 6, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27386/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27389/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devnexen
devnexen approved these changes Dec 6, 2019
View reviewed changes
cjihrig
cjihrig approved these changes Dec 6, 2019
View reviewed changes
@neheb

neheb commented Dec 7, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Not related?

14:32:07 not ok 1576 parallel/test-readline-async-iterators-destroy
14:32:07   ---
14:32:07   duration_ms: 2.143
14:32:07   severity: fail
14:32:07   exitcode: 1
14:32:07   stack: |-
14:32:07     events.js:279
14:32:07           throw er; // Unhandled 'error' event
14:32:07           ^
14:32:07     
14:32:07     Error: EBADF: bad file descriptor, read
14:32:07     Emitted 'error' event on ReadStream instance at:
14:32:07         at internal/fs/streams.js:186:12
14:32:07         at FSReqCallback.wrapper [as oncomplete] (fs.js:490:5) {
14:32:07       errno: -9,
14:32:07       code: 'EBADF',
14:32:07       syscall: 'read'
14:32:07     }
14:51:22 not ok 2661 sequential/test-heap-prof
14:51:22   ---
14:51:22   duration_ms: 120.871
14:51:22   severity: fail
14:51:22   exitcode: -15
14:51:22   stack: |-
14:51:22     timeout
14:51:22   ...
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Dec 7, 2019

Copy link
Copy Markdown
Member

Landed in 4e11920, thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Dec 7, 2019
addaleax pushed a commit that referenced this pull request Dec 7, 2019
@neheb @addaleax
src: don't use deprecated OpenSSL APIs
4e11920 
The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

PR-URL: #30812
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Dec 9, 2019
@neheb @targos
src: don't use deprecated OpenSSL APIs
ccf0917 
The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

PR-URL: #30812
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@neheb @targos
src: don't use deprecated OpenSSL APIs
a5a09ac 
The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

PR-URL: #30812
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@neheb @BethGriggs
src: don't use deprecated OpenSSL APIs
721ebf0 
The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

PR-URL: #30812
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@sam-github sam-github sam-github approved these changes
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@neheb @sam-github @nodejs-github-bot @addaleax @jasnell @Trott @cjihrig @devnexen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.