GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: scale keepalive timeouts for slow machines by bnoordhuis · Pull Request #30834 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Dec 7, 2019

Copy link
Copy Markdown
Member

The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828 (hopefully)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnoordhuis
test: scale keepalive timeouts for slow machines
94ae663 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: nodejs#30828
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 7, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27449/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis bnoordhuis mentioned this pull request Dec 7, 2019
Consistent test failure on v10.x #30828
Closed
richardlau
richardlau approved these changes Dec 7, 2019
View reviewed changes
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 7, 2019
@bnoordhuis

bnoordhuis commented Dec 7, 2019

Copy link
Copy Markdown
Member Author

The test failure is #30786 (SIGSEGV in addons/openssl-binding)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 7, 2019
View reviewed changes
lpinca
lpinca approved these changes Dec 7, 2019
View reviewed changes
trivikr
trivikr approved these changes Dec 7, 2019
View reviewed changes
gabrielschulhof
gabrielschulhof approved these changes Dec 7, 2019
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau richardlau added the lts-watch-v10.x label Dec 7, 2019
Trott
Trott approved these changes Dec 8, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27470/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2019 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27474/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gabrielschulhof

gabrielschulhof commented Dec 8, 2019

Copy link
Copy Markdown
Contributor

Shall we fast-track this PR?
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Dec 8, 2019
View reviewed changes
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 9, 2019
@Trott

Trott commented Dec 9, 2019

Copy link
Copy Markdown
Member

Landed in ba61253
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 9, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 9, 2019
@bnoordhuis @Trott
test: scale keepalive timeouts for slow machines
ba61253 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: nodejs#30828

PR-URL: nodejs#30834
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Dec 9, 2019
@bnoordhuis @targos
test: scale keepalive timeouts for slow machines
97e0efe 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@bnoordhuis @targos
test: scale keepalive timeouts for slow machines
e1eb6a6 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@bnoordhuis @BethGriggs
test: scale keepalive timeouts for slow machines
55a1a90 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
BethGriggs pushed a commit that referenced this pull request Feb 27, 2020
@bnoordhuis @BethGriggs
test: scale keepalive timeouts for slow machines
5484e06 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Sep 18, 2021
[Snyk] Fix for 2 vulnerabilities 137717unity/node#40
Open
[Snyk] Fix for 2 vulnerabilities sitedata/node#39
Open
[Snyk] Fix for 2 vulnerabilities molllyn1/node#29
Open
@Dmarch28 Dmarch28 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities Dmarch28/node#57
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#57
Open
@137717unity 137717unity mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities 137717unity/node#55
Open
@baby636 baby636 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities baby636/node#52
Open
@kissofire kissofire mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities kissofire/node#65
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#31
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities ron-a20/node#64
Open
@molllyn1 molllyn1 mentioned this pull request May 14, 2022
[Snyk] Fix for 1 vulnerabilities molllyn1/node#46
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
[Snyk] Fix for 22 vulnerabilities 137717unity/node#70
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
[Snyk] Fix for 22 vulnerabilities wedataintelligence/node#44
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
[Snyk] Fix for 22 vulnerabilities 137717unity/node#73
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
[Snyk] Fix for 21 vulnerabilities Rednickle/node-1#56
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#50
Open
This was referenced Sep 29, 2022
[Snyk] Fix for 24 vulnerabilities 137717unity/node#75
Open
[Snyk] Fix for 23 vulnerabilities Rednickle/node-1#60
Open
This was referenced Oct 5, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#51
Open
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#52
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#53
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
[Snyk] Fix for 24 vulnerabilities 137717unity/node#76
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#54
Open
This was referenced Oct 8, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#55
Open
[Snyk] Fix for 24 vulnerabilities 137717unity/node#77
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
[Snyk] Fix for 24 vulnerabilities 137717unity/node#78
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
[Snyk] Fix for 23 vulnerabilities Rednickle/node-1#63
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
[Snyk] Fix for 28 vulnerabilities aliceUnhinged613/node#98
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
[Snyk] Fix for 28 vulnerabilities wedataintelligence/node#87
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
[Snyk] Fix for 37 vulnerabilities baby636/node#110
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consistent test failure on v10.x

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@bnoordhuis @nodejs-github-bot @gabrielschulhof @Trott @lpinca @cjihrig @richardlau @BridgeAR @trivikr @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.