GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: mark tests as flaky by joaocgreis · Pull Request #30848 · nodejs/node

Conversation

@joaocgreis

@joaocgreis joaocgreis commented Dec 8, 2019

Copy link
Copy Markdown
Member

Mark a few tests that failed recently in master as flaky. Most of the tests are only marked flaky on Windows, except test-statwatcher that has failures documented for other platforms in its issue.

cc @nodejs/testing @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joaocgreis
test: mark tests as flaky
15fed98
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Dec 8, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27471/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Dec 8, 2019
View reviewed changes
@joaocgreis

joaocgreis commented Dec 8, 2019

Copy link
Copy Markdown
Member Author

Please approve this comment for fast-tracking.

This is easy to change back if there's any objection, and would be good to have in master as soon as possible to help reading CI results for other PRs.
gireeshpunathil, addaleax, Trott, and antsmartian reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis joaocgreis added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 8, 2019
@joaocgreis joaocgreis mentioned this pull request Dec 8, 2019
Test flakiness is in a critical state #30824
Closed
gireeshpunathil
gireeshpunathil approved these changes Dec 8, 2019
View reviewed changes
addaleax
addaleax approved these changes Dec 8, 2019
View reviewed changes
Trott
Trott approved these changes Dec 8, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27473/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27476/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit that referenced this pull request Dec 8, 2019
@joaocgreis @Trott
test: mark tests as flaky
a2cfb7d 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott

Trott commented Dec 8, 2019

Copy link
Copy Markdown
Member

Landed in a2cfb7d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 8, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@joaocgreis @targos
test: mark tests as flaky
305e45a 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@joaocgreis @targos
test: mark tests as flaky
dc1bc15 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@joaocgreis @BethGriggs
test: mark tests as flaky
2d39ed9 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
BethGriggs pushed a commit that referenced this pull request Feb 24, 2020
@joaocgreis @BethGriggs
test: mark tests as flaky
4b9a779 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
v10.20.0 proposal #31984
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joaocgreis @nodejs-github-bot @Trott @addaleax @richardlau @gireeshpunathil
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.