GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — console: unregister temporary error listener by ronag · Pull Request #30852 · nodejs/node

Conversation

@ronag

@ronag ronag commented Dec 8, 2019

Copy link
Copy Markdown
Member

I think the idea here was to swallow ONE error. Not sure if this actually makes any difference. Can the stream be re-used after having errored?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ronag
console: unregister temporary error listener
7a2e137
@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Dec 8, 2019
addaleax
addaleax approved these changes Dec 8, 2019
View reviewed changes
@Trott

Trott commented Dec 8, 2019

Copy link
Copy Markdown
Member

Is it worthwhile to write a test for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 8, 2019
View reviewed changes
@Trott

Trott commented Dec 8, 2019

Copy link
Copy Markdown
Member

@nodejs/console
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27652/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 14, 2019

Copy link
Copy Markdown
Member

Landed in d64c1dc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 14, 2019
Trott pushed a commit that referenced this pull request Dec 14, 2019
@ronag @Trott
console: unregister temporary error listener
d64c1dc 
PR-URL: #30852
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@ronag @MylesBorins
console: unregister temporary error listener
4f3eca5 
PR-URL: #30852
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
v13.5.0 proposal #31010
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag @targos
console: unregister temporary error listener
17fc4b0 
PR-URL: #30852
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ronag @BethGriggs
console: unregister temporary error listener
f54dc36 
PR-URL: #30852
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
This was referenced Apr 13, 2021
[Snyk] Security upgrade gatsby-transformer-remark from 2.8.27 to 4.0.0 Dmarch28/node#13
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.22 to 4.0.0 kissofire/node#33
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.45 to 4.0.0 ron-a20/node#31
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.45 to 4.0.0 aliceUnhinged613/node#23
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.22 to 4.0.0 meghasfdc/node#33
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.45 to 4.0.0 sitedata/node#23
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.45 to 4.0.0 Rednickle/node-1#20
Open
[Snyk] Security upgrade gatsby-transformer-remark from 2.6.45 to 4.0.0 137717unity/node#24
Open
This was referenced Sep 17, 2021
[Snyk] Fix for 2 vulnerabilities baby636/node#28
Open
[Snyk] Fix for 2 vulnerabilities ron-a20/node#47
Open
[Snyk] Fix for 2 vulnerabilities Rednickle/node-1#34
Open
[Snyk] Fix for 2 vulnerabilities aliceUnhinged613/node#37
Open
This was referenced Sep 18, 2021
[Snyk] Fix for 2 vulnerabilities 137717unity/node#40
Open
[Snyk] Fix for 2 vulnerabilities sitedata/node#39
Open
[Snyk] Fix for 2 vulnerabilities molllyn1/node#29
Open
@Dmarch28 Dmarch28 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities Dmarch28/node#57
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#57
Open
@137717unity 137717unity mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities 137717unity/node#55
Open
@baby636 baby636 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities baby636/node#52
Open
@kissofire kissofire mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities kissofire/node#65
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#31
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2022
[Snyk] Fix for 1 vulnerabilities ron-a20/node#64
Open
@molllyn1 molllyn1 mentioned this pull request May 14, 2022
[Snyk] Fix for 1 vulnerabilities molllyn1/node#46
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
[Snyk] Fix for 22 vulnerabilities 137717unity/node#70
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
[Snyk] Fix for 22 vulnerabilities wedataintelligence/node#44
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
[Snyk] Fix for 22 vulnerabilities 137717unity/node#73
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
[Snyk] Fix for 21 vulnerabilities Rednickle/node-1#56
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#50
Open
This was referenced Sep 29, 2022
[Snyk] Fix for 24 vulnerabilities 137717unity/node#75
Open
[Snyk] Fix for 23 vulnerabilities Rednickle/node-1#60
Open
This was referenced Oct 5, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#51
Open
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#52
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#53
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
[Snyk] Fix for 24 vulnerabilities 137717unity/node#76
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#54
Open
This was referenced Oct 8, 2022
[Snyk] Fix for 24 vulnerabilities wedataintelligence/node#55
Open
[Snyk] Fix for 24 vulnerabilities 137717unity/node#77
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
[Snyk] Fix for 24 vulnerabilities 137717unity/node#78
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
[Snyk] Fix for 23 vulnerabilities Rednickle/node-1#63
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
[Snyk] Fix for 28 vulnerabilities aliceUnhinged613/node#98
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
[Snyk] Fix for 28 vulnerabilities wedataintelligence/node#87
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
[Snyk] Fix for 37 vulnerabilities baby636/node#110
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. console Issues and PRs related to the console subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ronag @Trott @nodejs-github-bot @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.