GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: replace every Symbol.for by SymbolFor by Sebastien-Ahkrin · Pull Request #30857 · nodejs/node

Conversation

@Sebastien-Ahkrin

@Sebastien-Ahkrin Sebastien-Ahkrin commented Dec 8, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Just replacing every Symbol.for by SymbolFor in the lib/* folder

And adding SymbolFor in the import

const {
  // [...]
  SymbolFor,
} = primordials;

This task was given to me by @targos thanks again ❤️
I hope this new PR will help you :x

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and lin7sh reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs involving general changes in the lib/ or src/ directories. label Dec 8, 2019
@Sebastien-Ahkrin
Sebastien-Ahkrin force-pushed the SymbolFor branch 3 times, most recently from 52470c1 to ebdc308 Compare December 8, 2019 18:12
@Sebastien-Ahkrin
lib: replace every Symbol.for by SymbolFor primordials
163e874
@Sebastien-Ahkrin
Sebastien-Ahkrin force-pushed the SymbolFor branch from ebdc308 to 163e874 Compare December 8, 2019 18:13
targos
targos approved these changes Dec 8, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27500/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 8, 2019
View reviewed changes
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Dec 8, 2019

Copy link
Copy Markdown
Contributor Author

Refs: #30697
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27515/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Dec 9, 2019
View reviewed changes
targos pushed a commit that referenced this pull request Dec 11, 2019
@Sebastien-Ahkrin @targos
lib: replace every Symbol.for by SymbolFor primordials
11465d3 
PR-URL: #30857
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos

targos commented Dec 11, 2019

Copy link
Copy Markdown
Member

Landed in 11465d3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Dec 11, 2019
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
@Sebastien-Ahkrin @MylesBorins
lib: replace every Symbol.for by SymbolFor primordials
39898a9 
PR-URL: #30857
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace every Symbol.for by SymbolFor primordials
54aa3b9 
PR-URL: #30857
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace every Symbol.for by SymbolFor primordials
993c419 
PR-URL: #30857
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
@Leko Leko mentioned this pull request Oct 1, 2020
primordials access check can be improved #35449
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark molllyn1/node#7
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Sebastien-Ahkrin @nodejs-github-bot @targos @cjihrig @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.