GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: replace Symbol.iterator by SymbolIterator by Sebastien-Ahkrin · Pull Request #30859 · nodejs/node

Conversation

@Sebastien-Ahkrin

@Sebastien-Ahkrin Sebastien-Ahkrin commented Dec 8, 2019

Copy link
Copy Markdown
Contributor

Just replaced every Symbol.iterator by SymbolIterator in the lib/* folder

For this, i just have added SymbolIterator in the import

const {
  // [...]
  SymbolIterator,
} = primordials;

I hope this pull request will help you ! 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Sebastien-Ahkrin
lib: replace Symbol.iterator by SymbolIterator
ef0178e
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Dec 8, 2019

Copy link
Copy Markdown
Contributor Author

Refs: #30697
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Dec 9, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27516/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devnexen
devnexen approved these changes Dec 9, 2019
View reviewed changes
cjihrig
cjihrig approved these changes Dec 9, 2019
View reviewed changes
@targos

targos commented Dec 11, 2019

Copy link
Copy Markdown
Member

Landed in c101251
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Dec 11, 2019
targos pushed a commit that referenced this pull request Dec 11, 2019
@Sebastien-Ahkrin @targos
lib: replace Symbol.iterator by SymbolIterator
c101251 
PR-URL: #30859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
@Sebastien-Ahkrin @MylesBorins
lib: replace Symbol.iterator by SymbolIterator
64ab5c9 
PR-URL: #30859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace Symbol.iterator by SymbolIterator
22df5dc 
PR-URL: #30859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace Symbol.iterator by SymbolIterator
fb18ad4 
PR-URL: #30859
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@targos targos targos approved these changes
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Sebastien-Ahkrin @nodejs-github-bot @targos @cjihrig @devnexen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.