GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify Tier 2 implications in BUILDING.md by Trott · Pull Request #30866 · nodejs/node

Conversation

@Trott

@Trott Trott commented Dec 9, 2019

Copy link
Copy Markdown
Member

Clarify the explanation of Tier 2 platforms and binary releases.

@nodejs/build especially @rvagg

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Dec 9, 2019
bnoordhuis
bnoordhuis approved these changes Dec 9, 2019
View reviewed changes
targos
targos approved these changes Dec 9, 2019
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 9, 2019
BethGriggs
BethGriggs approved these changes Dec 9, 2019
View reviewed changes
cjihrig
cjihrig approved these changes Dec 9, 2019
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Dec 9, 2019
View reviewed changes
richardlau
richardlau approved these changes Dec 9, 2019
View reviewed changes
lpinca
lpinca approved these changes Dec 9, 2019
View reviewed changes
trivikr
trivikr approved these changes Dec 9, 2019
View reviewed changes
mhdawson
mhdawson approved these changes Dec 9, 2019
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rvagg
rvagg approved these changes Dec 10, 2019
View reviewed changes

@rvagg rvagg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to squint to see the difference. I think you're just removing the passive, us-focused voice and making it active, user-focused, right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Dec 10, 2019

Copy link
Copy Markdown
Member Author

I have to squint to see the difference. I think you're just removing the passive, us-focused voice and making it active, user-focused, right?

Yes. Subjectively, I find "are acceptable where necessary due to infrastructure concerns" makes me wonder if I didn't understand it correctly. So replacing that with a more direct active voice seems easier-to-understand, at least to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
doc: clarify Tier 2 implications in BUILDING.md
76cbb66 
Clarify the explanation of Tier 2 platforms and binary releases.

PR-URL: nodejs#30866
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@Trott
Trott force-pushed the build-convo branch from 86c39c6 to 76cbb66 Compare December 11, 2019 14:44
@Trott
Trott merged commit 76cbb66 into nodejs:master Dec 11, 2019
@Trott

Trott commented Dec 11, 2019

Copy link
Copy Markdown
Member Author

Landed in 76cbb66
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
@Trott @MylesBorins
doc: clarify Tier 2 implications in BUILDING.md
9d1c793 
Clarify the explanation of Tier 2 platforms and binary releases.

PR-URL: #30866
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Trott @targos
doc: clarify Tier 2 implications in BUILDING.md
3ac40b9 
Clarify the explanation of Tier 2 platforms and binary releases.

PR-URL: #30866
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
doc: clarify Tier 2 implications in BUILDING.md
7b3e269 
Clarify the explanation of Tier 2 platforms and binary releases.

PR-URL: #30866
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@trivikr trivikr trivikr approved these changes
+3 more reviewers
@rvagg rvagg rvagg approved these changes
@targos targos targos approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@Trott @bnoordhuis @rvagg @lpinca @targos @cjihrig @richardlau @gireeshpunathil @BethGriggs @mhdawson @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.