GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix missing arch suffix in binary tar name by legendecas · Pull Request #30877 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Dec 10, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@legendecas
build: fix missing x64 arch suffix in binary tar name
07e1150
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Dec 10, 2019
@legendecas legendecas changed the title build: fix missing x64 arch suffix in binary tar name build: fix missing arch suffix in binary tar name Dec 10, 2019
devnexen
devnexen approved these changes Dec 10, 2019
View reviewed changes
@legendecas

legendecas commented Dec 13, 2019

Copy link
Copy Markdown
Member Author

@nodejs/build wondering if this misaligned endif was made by intention or not, may I ask for reviews on the PR from build team forks?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Dec 13, 2019
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm assuming the release jobs (I can't see them) have the ARCH environment variable set, which is why this wasn't spotted before or cause issues for the releases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27617/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Dec 13, 2019

Copy link
Copy Markdown
Member

cc @nodejs/build-files
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 13, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27634/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27646/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit that referenced this pull request Dec 14, 2019
@legendecas @Trott
build: fix missing x64 arch suffix in binary tar name
1807c3e 
PR-URL: #30877
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott

Trott commented Dec 14, 2019

Copy link
Copy Markdown
Member

Landed in 1807c3e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 14, 2019
@legendecas
legendecas deleted the build branch December 14, 2019 05:47
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@legendecas @MylesBorins
build: fix missing x64 arch suffix in binary tar name
60225c1 
PR-URL: #30877
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
v13.5.0 proposal #31010
Merged
@rvagg

rvagg commented Dec 20, 2019

Copy link
Copy Markdown
Member

👍

I've been very careful to make sure to be explicit with ARCH (and some others) on release machines which is why this probably hasn't been caught before.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jan 14, 2020
@legendecas @targos
build: fix missing x64 arch suffix in binary tar name
1811b1a 
PR-URL: #30877
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@legendecas @BethGriggs
build: fix missing x64 arch suffix in binary tar name
dc7a232 
PR-URL: #30877
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@legendecas @nodejs-github-bot @richardlau @Trott @rvagg @devnexen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.