GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: minor fix equality comparison by PW486 · Pull Request #30898 · nodejs/node

Conversation

@PW486

@PW486 PW486 commented Dec 11, 2019

Copy link
Copy Markdown
Contributor

Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and devnexen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@PW486
lib: minor fix equality comparison
8e7e691 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 11, 2019
BridgeAR
BridgeAR approved these changes Dec 11, 2019
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a green CI

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27584/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devnexen
devnexen approved these changes Dec 12, 2019
View reviewed changes
@targos

targos commented Dec 12, 2019

Copy link
Copy Markdown
Member

don't we still treat punycode as an external dependency that we don't patch directly?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Dec 12, 2019

Copy link
Copy Markdown
Member

@targos not anymore as far as I can tell. We did update e.g. var.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott requested changes Dec 13, 2019
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a very specific reason that we used == in prof_polyfill but I don't recall what it was.... Going to "request changes" for a bit while I dig through logs to try to find out. Sorry about that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Dec 13, 2019

Copy link
Copy Markdown
Member

There was a very specific reason that we used == in prof_polyfill but I don't recall what it was.... Going to "request changes" for a bit while I dig through logs to try to find out. Sorry about that.

Argh, I see it was recently de-var'ed which I think might also be a problem. I might be confusing it with another file though.

@targos not anymore as far as I can tell. We did update e.g. var.

But it looks like maybe we upstreamed that change....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 13, 2019

Copy link
Copy Markdown
Member

This should probably be split into two commits, one for each file?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 13, 2019

Copy link
Copy Markdown
Member

@nodejs/v8 @matthewloring Am I wrong about == in v8_prof_polyfill.js being significant somehow? I'm guessing I'm wrong/mistaken/misremembering but I would really prefer to have that confirmed by someone knowledgable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Dec 13, 2019

Copy link
Copy Markdown
Member

@Trott here's an overview for loose equalities: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using

Objects with a Symbol.toPrimitive or toString attached would work differently now (they could match before). Other comparison will not be impacted.

I do not know if that was intentional but I doubt it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 13, 2019

Copy link
Copy Markdown
Member

@Trott here's an overview for loose equalities: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using

Objects with a Symbol.toPrimitive or toString attached would work differently now (they could match before). Other comparison will not be impacted.

I do not know if that was intentional but I doubt it.

I thought it had to do with side effects in V8 under the hood that would affect profiling but not anything normally visible to the end user. I'm probably wrong and will remove my request for changes.
PW486 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Dec 13, 2019
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27644/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27666/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit that referenced this pull request Dec 14, 2019
@PW486 @Trott
lib: use strict equality comparison
9c460e1 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott

Trott commented Dec 14, 2019

Copy link
Copy Markdown
Member

Landed in 9c460e1.

Thanks for the contribution! 🎉
PW486 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Dec 14, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@PW486 @MylesBorins
lib: use strict equality comparison
2430dd8 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
v13.5.0 proposal #31010
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@PW486 @targos
lib: use strict equality comparison
9b730ad 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@PW486 @BethGriggs
lib: use strict equality comparison
1c2d699 
Change '==' to '===' in v8_prof_polyfill.js, punycode.js.

PR-URL: #30898
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@PW486 @nodejs-github-bot @targos @BridgeAR @Trott @devnexen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.