GeezerVison

Copy link

Copy Markdown

Member

BridgeAR force-pushed the 2019-12-27-repl-substring-history-search branch 2 times, most recently from 5b21b6c to a36f1a8 Compare January 4, 2020 08:44

BridgeAR marked this pull request as ready for review January 4, 2020 11:14

BridgeAR requested review from Trott, benjamingr, jasnell, srl295 and targos January 4, 2020 11:18

addaleax reviewed Jan 5, 2020

View reviewed changes

jasnell reviewed Jan 7, 2020

View reviewed changes

BridgeAR force-pushed the 2019-12-27-repl-substring-history-search branch from 97ecd26 to 6c73393 Compare January 8, 2020 09:57

BridgeAR force-pushed the 2019-12-27-repl-substring-history-search branch from 6c73393 to 9e958f3 Compare January 8, 2020 11:00

The preview had an off by one error in case colors where deactivated
and did not take fullwidth unicode characters into account when
displaying the preview.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This improves the current history search feature by adding substring
based history search similar to ZSH. In case the `UP` or `DOWN`
buttons are pressed after writing a few characters, the start string
up to the current cursor is used to search the history.

All other history features work exactly as they used to.

PR-URL: nodejs#31112
Fixes: nodejs#28437
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Skip history entries that are identical to the currently visible line
to improve the user experience.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Reaching the history end caused the last entry to be persistent.
That way there's no actualy feedback to the user that the history
end is reached. Instead, visualize the original input line and keep
the history index at the history end in case the user wants to go
back again.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

1. Simplify the getStringWidth function used by Intl builds by removing
   dead code (the options were unused) and by refactoring the logic.
2. Improve the getStringWidth unicode handling used by non-Intl builds.
   The getStringWidth function returned the wrong width for multiple
   inputs. It's now improved by supporting various zero width characters
   and more full width characters.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This moves the charLengthLeft() and charLengthAt() into the internal
readline file. This allows sharing the functions internally with
other code.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This improves the performance in GetColumnWidth for full width
characters.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

The option is now set to true by default. Most terminals do not have
full emoji support and visualize emojis with zero width joiners as
individual emojis.
Also verify that at least one argument is always passed through to the
function and remove support for passing through code points. Only
accept strings from now on to simplify the API.

PR-URL: nodejs#31112
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#31112
Fixes: nodejs#25272
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>