GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Document readline keybindings by HarshithaKP · Pull Request #31256 · nodejs/node

Conversation

HarshithaKP commented Jan 8, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This is a rework of closed pr #20825
fixes: #20814

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

HarshithaKP added 2 commits

January 7, 2020 07:37


          doc: readline keybindings

96872ea

Added readline keybindings table to document


          doc: document readline keybindings

0de07fc

This is a rework of closed pr nodejs#20825
fixes: nodejs#20814

nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label

Jan 8, 2020

HarshithaKP commented Jan 8, 2020

Copy link

Copy Markdown

Member Author

cc: @shobhitchittora

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

antsmartian reviewed

Jan 8, 2020

View reviewed changes

Comment thread

doc/api/readline.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

antsmartian reviewed

Jan 8, 2020

View reviewed changes

Comment thread

doc/api/readline.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR reviewed

Jan 8, 2020

View reviewed changes

BridgeAR left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshithaKP thank you very much for working on this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.


          fixup: address review comments

8d2ccef

BridgeAR reviewed

Jan 8, 2020

View reviewed changes

BridgeAR left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up so quickly! This almost looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

doc/api/readline.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/readline.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR added the wip Issues and PRs that are still a work in progress. label

Jan 9, 2020


          fixup: address review comments

b06aee5

shobhitchittora commented Jan 10, 2020

Copy link

Copy Markdown

Contributor

Thanks @HarshithaKP for picking this up.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

HarshithaKP commented Jan 10, 2020

Copy link

Copy Markdown

Member Author

Ping @BridgeAR @antsmartian, I believe I addressed all the suggestions. Please have a look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR previously approved these changes

Jan 10, 2020

View reviewed changes

BridgeAR left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left some nits.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

doc/api/repl.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/repl.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/repl.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR removed the wip Issues and PRs that are still a work in progress. label

Jan 10, 2020

BridgeAR dismissed their stale review

January 10, 2020 15:03

The comments have to be addressed before this can land.

jasnell approved these changes

Jan 12, 2020

View reviewed changes

jasnell left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @BridgeAR's suggestions applied.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fixup: address review comments

d0c4458

BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Jan 13, 2020

BridgeAR approved these changes

Jan 13, 2020

View reviewed changes

BridgeAR pushed a commit that referenced this pull request

Jan 13, 2020


          doc: document readline key bindings

027eaac

This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

BridgeAR commented Jan 13, 2020

Copy link

Copy Markdown

Member

Landed in 027eaac 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR closed this

Jan 13, 2020

MylesBorins pushed a commit that referenced this pull request

Jan 16, 2020


          doc: document readline key bindings

b9aca78

This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

codebytere mentioned this pull request

Jan 16, 2020

v13.7.0 proposal #31382

Merged

codebytere pushed a commit that referenced this pull request

Mar 14, 2020


          doc: document readline key bindings

c72fff6

This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

This was referenced Mar 15, 2020

[v12.x backport] async_hooks: add executionAsyncResource #32131

Closed

[v12.x] doc: remove reverse-i-search link #32282

Closed

addaleax commented Mar 16, 2020

Copy link

Copy Markdown

Member

@codebytere Just fyi, this breaks make test for me on v12.x because there’s broken links in the documentation – I’ll still open backports for the other PRs as you suggested and try to make sure that tests pass as much as possible, but you may want to remove this commit from v12.x-staging

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added the backport-blocked-v12.x label

Apr 18, 2020

targos commented Apr 18, 2020

Copy link

Copy Markdown

Member

Let's wait for #31006 to land this one on v12.x

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos removed author ready

PRs with CI started, the required approvals, and no outstanding review comments.

backport-blocked-v12.x labels

Apr 25, 2020

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020


          doc: document readline key bindings

cc9fa9f

This documents all readline key bindings. It is a rework of
nodejs#20825

PR-URL: nodejs#31256
Fixes: nodejs#20814
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

targos pushed a commit that referenced this pull request

Apr 28, 2020


          doc: document readline key bindings

1d2565b

This documents all readline key bindings. It is a rework of
#20825

PR-URL: #31256
Fixes: #20814
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

targos mentioned this pull request

May 2, 2020

v12.17.0 release proposal #33197

Merged

Reviewers

jasnell

jasnell approved these changes

BridgeAR

BridgeAR approved these changes

+1 more reviewer

antsmartian

antsmartian left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: add doc for tty writes ( readline.js / REPL )

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

HarshithaKP commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

HarshithaKP commented Jan 8, 2020

Uh oh!

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shobhitchittora commented Jan 10, 2020

Uh oh!

HarshithaKP commented Jan 10, 2020

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Jan 13, 2020

Uh oh!

addaleax commented Mar 16, 2020

Uh oh!

targos commented Apr 18, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

HarshithaKP commented Jan 8, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.