GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update README to make Node.js description clearer by carterbancroft · Pull Request #31266 · nodejs/node

Conversation

@carterbancroft

@carterbancroft carterbancroft commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

Fixes: #24872

This PR updates the README's original description:

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine.

To:

Node.js is an open-source, cross-platform, JavaScript runtime environment. It executes JavaScript code outside of a browser

Based on the two sentence suggestion from the issue discussion.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devnexen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@carterbancroft
doc: update README to make node.js description clearer
93f574b 
Fixes: nodejs#24872
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jan 9, 2020
devnexen
devnexen approved these changes Jan 9, 2020
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Jan 9, 2020
View reviewed changes
lpinca
lpinca approved these changes Jan 9, 2020
View reviewed changes
BridgeAR
BridgeAR approved these changes Jan 9, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 9, 2020
Trott
Trott approved these changes Jan 10, 2020
View reviewed changes
@Trott

Trott commented Jan 11, 2020

Copy link
Copy Markdown
Member

Landed in 6d44308
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Jan 11, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 11, 2020
@carterbancroft @Trott
doc: update README to make Node.js description clearer
6d44308 
Fixes: nodejs#24872

PR-URL: nodejs#31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@carterbancroft @MylesBorins
doc: update README to make Node.js description clearer
deff600 
Fixes: #24872

PR-URL: #31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@carterbancroft @codebytere
doc: update README to make Node.js description clearer
07c3b6d 
Fixes: #24872

PR-URL: #31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@carterbancroft @codebytere
doc: update README to make Node.js description clearer
cb40a1a 
Fixes: #24872

PR-URL: #31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need change in the read me file

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@carterbancroft @Trott @lpinca @devnexen @gireeshpunathil @BridgeAR @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.