GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — vm: add code cache support for SourceTextModule by devsnek · Pull Request #31278 · nodejs/node

Conversation

@devsnek

@devsnek devsnek commented Jan 9, 2020

Copy link
Copy Markdown
Member

Fixes #31233

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, devnexen, and lin7sh reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@devsnek devsnek added the vm Issues and PRs related to the vm subsystem. label Jan 9, 2020
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Jan 9, 2020
@devsnek devsnek removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Jan 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28327/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek

devsnek commented Jan 9, 2020

Copy link
Copy Markdown
Member Author

If you are reviewing this PR, please also go check out #30709. It has been open since late November and really needs reviews.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28330/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jan 10, 2020
View reviewed changes
Trott
Trott approved these changes Jan 11, 2020
View reviewed changes
@Trott Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 11, 2020
@Trott

Trott commented Jan 11, 2020

Copy link
Copy Markdown
Member

@nodejs/vm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos reviewed Jan 11, 2020
View reviewed changes
Comment thread doc/api/vm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
devsnek force-pushed the vm-stm-code-cache branch from 64f2382 to daeeb16 Compare January 11, 2020 21:01
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28367/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR reviewed Jan 11, 2020
View reviewed changes
Comment thread lib/internal/vm/module.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Jan 12, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 12, 2020
@nodejs-github-bot

nodejs-github-bot commented Jan 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28407/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devsnek
vm: add code cache support for SourceTextModule
b810e67 
PR-URL: nodejs#31278
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@devsnek
devsnek force-pushed the vm-stm-code-cache branch from daeeb16 to b810e67 Compare January 12, 2020 22:44
@devsnek
devsnek merged commit b810e67 into nodejs:master Jan 12, 2020
@devsnek
devsnek deleted the vm-stm-code-cache branch January 12, 2020 22:44
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@devsnek @MylesBorins
vm: add code cache support for SourceTextModule
27564a4 
PR-URL: #31278
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
@targos targos removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@devsnek @targos
vm: add code cache support for SourceTextModule
0aeb955 
PR-URL: nodejs#31278
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@devsnek @targos
vm: add code cache support for SourceTextModule
eda6665 
PR-URL: #31278
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
@SimonSchick SimonSchick mentioned this pull request Oct 10, 2026
feat: backfill various missing node APIs DefinitelyTyped/DefinitelyTyped#75760
Open
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR left review comments
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
+1 more reviewer
@targos targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

semver-minor PRs that contain new features and should be released in the next minor version. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow code caches to be created for modules

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@devsnek @nodejs-github-bot @Trott @jasnell @addaleax @targos @BridgeAR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.