GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: stricten readline keypress failure test condition by BridgeAR · Pull Request #31300 · nodejs/node

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Jan 10, 2020

Copy link
Copy Markdown
Member

This verifies that the thrown error is the expected one. That was
not tested before.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BridgeAR
test: stricten readline keypress failure test condition
e67eb2a 
This verifies that the thrown error is the expected one. That was
not tested before.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 10, 2020
addaleax
addaleax approved these changes Jan 10, 2020
View reviewed changes
lpinca
lpinca approved these changes Jan 10, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28358/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZYSzys
ZYSzys approved these changes Jan 11, 2020
View reviewed changes
@ZYSzys ZYSzys added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 11, 2020
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28374/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Jan 12, 2020
View reviewed changes
Comment thread test/parallel/test-readline-interface.js
} catch { }
assert.throws(
() => fi.emit('data', 'fooX'),
(e) => {

@Trott Trott Jan 12, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a validation function, can't this just be err?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@BridgeAR BridgeAR Jan 12, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would also work but I wanted to have a reference equality check. That would not be checked if I'd use err directly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott approved these changes Jan 12, 2020
View reviewed changes
BridgeAR added a commit that referenced this pull request Jan 12, 2020
@BridgeAR
test: stricten readline keypress failure test condition
7952467 
This verifies that the thrown error is the expected one. That was
not tested before.

PR-URL: #31300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR

BridgeAR commented Jan 12, 2020

Copy link
Copy Markdown
Member Author

Landed in 7952467 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Jan 12, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@BridgeAR @MylesBorins
test: stricten readline keypress failure test condition
4244080 
This verifies that the thrown error is the expected one. That was
not tested before.

PR-URL: #31300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
@BridgeAR
BridgeAR deleted the 2020-01-10-add-stricter-readline-test branch January 20, 2020 12:10
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@BridgeAR @codebytere
test: stricten readline keypress failure test condition
5e613ff 
This verifies that the thrown error is the expected one. That was
not tested before.

PR-URL: #31300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@BridgeAR @codebytere
test: stricten readline keypress failure test condition
20167fe 
This verifies that the thrown error is the expected one. That was
not tested before.

PR-URL: #31300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@BridgeAR @nodejs-github-bot @Trott @addaleax @lpinca @ZYSzys
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.