GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add GeoffreyBooth to collaborators by GeoffreyBooth · Pull Request #31306 · nodejs/node

Conversation

@GeoffreyBooth

@GeoffreyBooth GeoffreyBooth commented Jan 10, 2020

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@GeoffreyBooth
doc: add GeoffreyBooth to collaborators
54de27d
@GeoffreyBooth GeoffreyBooth added doc Issues and PRs related to Node.js documentation. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jan 10, 2020
@GeoffreyBooth GeoffreyBooth assigned MylesBorins Jan 10, 2020
MylesBorins
MylesBorins approved these changes Jan 10, 2020
View reviewed changes

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins

MylesBorins commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

Fasttrack?
cjihrig, MylesBorins, bengl, and richardlau reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Jan 10, 2020
View reviewed changes
bengl
bengl approved these changes Jan 10, 2020
View reviewed changes
@GeoffreyBooth

GeoffreyBooth commented Jan 10, 2020

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4124/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Jan 10, 2020
View reviewed changes
GeoffreyBooth added a commit that referenced this pull request Jan 10, 2020
@GeoffreyBooth
doc: add GeoffreyBooth to collaborators
3bcb2e1 
PR-URL: #31306
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@GeoffreyBooth

GeoffreyBooth commented Jan 10, 2020

Copy link
Copy Markdown
Member Author

Landed in 3bcb2e1
richardlau and MylesBorins reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth closed this Jan 10, 2020
@GeoffreyBooth
GeoffreyBooth deleted the add-geoffreybooth-to-collaborators branch January 10, 2020 20:54
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@GeoffreyBooth @MylesBorins
doc: add GeoffreyBooth to collaborators
9c58aa4 
PR-URL: #31306
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere added a commit that referenced this pull request Jan 16, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
20b7365 
Notable changes:

* **deps**:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
* **doc**:
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
* **process**:
  * allow monitoring uncaughtException (Gerhard Stoebich) [#31257](#31257)
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere added a commit that referenced this pull request Jan 17, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
a283d37 
Notable changes:

* **deps**:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
* **doc**:
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
* **process**:
  * allow monitoring uncaughtException (Gerhard Stoebich) [#31257](#31257)
codebytere added a commit to codebytere/node that referenced this pull request Jan 19, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
d116035 
Notable changes:

* **deps**:
  * upgrade npm to 6.13.6 (Ruy Adorno) [nodejs#31304](nodejs#31304)
* **doc**:
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [nodejs#31306](nodejs#31306)
* **process**:
  * allow monitoring uncaughtException (Gerhard Stoebich) [nodejs#31257](nodejs#31257)

PR-URL: nodejs#31382
codebytere added a commit that referenced this pull request Jan 20, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
d1e8e6f 
Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* doc:
  * add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257

PR-URL: #31382
codebytere added a commit that referenced this pull request Jan 21, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
bbab963 
Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
  * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306

PR-URL: #31382
codebytere added a commit that referenced this pull request Jan 21, 2020
@codebytere
2020-01-21, Version 13.7.0 (Current)
a484f1a 
Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
  * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306

PR-URL: #31382
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@GeoffreyBooth @codebytere
doc: add GeoffreyBooth to collaborators
096388d 
PR-URL: #31306
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@GeoffreyBooth @codebytere
doc: add GeoffreyBooth to collaborators
97c12f1 
PR-URL: #31306
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere added a commit that referenced this pull request Mar 17, 2020
@codebytere
2020-03-24 Version 12.16.2 (LTS)
393f76c 
Notable changes:

* [f0b5f9f] - doc: add ronag to collaborators (Robert Nagy) #31498
* [7a8963b] - deps: upgrade npm to 6.13.6 (Ruy Adorno) #31304
* [97c12f1] - doc: add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
codebytere added a commit that referenced this pull request Mar 17, 2020
@codebytere
2020-03-24 Version 12.16.2 (LTS)
37306be 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
codebytere added a commit that referenced this pull request Mar 22, 2020
@codebytere
2020-03-24 Version 12.16.2 (LTS)
7780ccd 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
codebytere added a commit that referenced this pull request Mar 24, 2020
@codebytere
2020-03-31 Version 12.16.2 (LTS)
552532c 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Mar 30, 2020
@codebytere
2020-04-04 Version 12.16.2 (LTS)
345054f 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 1, 2020
@codebytere
2020-04-04 Version 12.16.2 (LTS)
6047863 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 3, 2020
@codebytere
2020-04-07 Version 12.16.2 (LTS)
f83c71a 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 4, 2020
@codebytere
2020-04-07 Version 12.16.2 (LTS)
eb5f794 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 5, 2020
@codebytere
2020-04-07 Version 12.16.2 (LTS)
d073a68 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 8, 2020
@codebytere
2020-04-08 Version 12.16.2 (LTS)
3443e3a 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 8, 2020
@codebytere
2020-04-08 Version 12.16.2 'Erbium' (LTS)
6ec0285 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@codebytere @BethGriggs
2020-04-08 Version 12.16.2 'Erbium' (LTS)
fee8cb1 
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bengl bengl bengl approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@MylesBorins MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@MylesBorins MylesBorins

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@GeoffreyBooth @MylesBorins @bengl @cjihrig @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.