GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repl: prevent previews during pasting by BridgeAR · Pull Request #31315 · nodejs/node

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Jan 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is based on #31288 and therefore the two first commits should be ignored. I'll rebase as soon as the other PR lands.
Update: done.

This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@BridgeAR BridgeAR added the blocked PRs that are blocked by other issues or PRs. label Jan 11, 2020
@nodejs-github-bot nodejs-github-bot added readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. labels Jan 11, 2020
@BridgeAR
BridgeAR force-pushed the 2020-01-11-repl-prevent-previews-during-pasting branch from 7dabd1e to fe738a3 Compare January 11, 2020 22:19
@BridgeAR BridgeAR removed the blocked PRs that are blocked by other issues or PRs. label Jan 11, 2020
@BridgeAR
BridgeAR force-pushed the 2020-01-11-repl-prevent-previews-during-pasting branch from fe738a3 to eea1c73 Compare January 11, 2020 22:24
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28372/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jan 12, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 12, 2020
@BridgeAR
repl: do not preview while pasting code
5f1cee3 
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.
@BridgeAR
BridgeAR force-pushed the 2020-01-11-repl-prevent-previews-during-pasting branch from eea1c73 to 5f1cee3 Compare January 12, 2020 22:30
@BridgeAR

BridgeAR commented Jan 12, 2020

Copy link
Copy Markdown
Member Author

Rebased due to conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28417/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Jan 12, 2020

Copy link
Copy Markdown
Member Author

@nodejs/repl @nodejs/readline PTAL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jan 13, 2020
View reviewed changes
JungMinu
JungMinu approved these changes Jan 13, 2020
View reviewed changes
BridgeAR added a commit that referenced this pull request Jan 13, 2020
@BridgeAR
repl: do not preview while pasting code
c3b702f 
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: #31315
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@BridgeAR

BridgeAR commented Jan 13, 2020

Copy link
Copy Markdown
Member Author

Landed in c3b702f 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Jan 13, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@BridgeAR @MylesBorins
repl: do not preview while pasting code
85926d4 
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: #31315
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
@BridgeAR
BridgeAR deleted the 2020-01-11-repl-prevent-previews-during-pasting branch January 20, 2020 12:09
@codebytere

codebytere commented Mar 14, 2020

Copy link
Copy Markdown
Member

@BridgeAR sorry for the many pings - this is in the group needing manual backport to 12 if it should indeed go there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere added the backport-blocked-v12.x label Mar 14, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
repl: do not preview while pasting code
1ce305f 
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: nodejs#31315
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
repl: do not preview while pasting code
ce5c9d7 
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: #31315
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
@addaleax addaleax added dont-land-on-v12.x and removed backport-blocked-v12.x labels Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@JungMinu JungMinu JungMinu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@BridgeAR @nodejs-github-bot @codebytere @jasnell @Trott @JungMinu @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.