GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — minor vcbuild.bat fixups by richardlau · Pull Request #31338 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Jan 13, 2020

Copy link
Copy Markdown
Member

The first commit adds the vs2019 option (added by #28781) to the help output.

The second commit removes the enable-vtune option which was removed from configure.py in #28522 and results in a no such option error from configure if used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. windows Issues and PRs related to the Windows platform. labels Jan 13, 2020
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28423/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gengjiawen
gengjiawen approved these changes Jan 13, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28424/ (✔️)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 13, 2020
Trott
Trott approved these changes Jan 14, 2020
View reviewed changes
richardlau added 2 commits January 15, 2020 00:40
@richardlau
build: add vs2019 to vcbuild.bat help
d830ff8 
PR-URL: nodejs#31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau
build: remove enable_vtune from vcbuild.bat
e67dc1e 
vcbuild.bat wasn't updated when vtune support was removed in
nodejs#28522

Refs: nodejs#28522
PR-URL: nodejs#31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau
richardlau force-pushed the vcbuild branch from d2dc896 to e67dc1e Compare January 15, 2020 05:42
@richardlau richardlau self-assigned this Jan 15, 2020
@richardlau
richardlau merged commit e67dc1e into nodejs:master Jan 15, 2020
@richardlau

richardlau commented Jan 15, 2020

Copy link
Copy Markdown
Member Author

Landed in dcbf9da...e67dc1e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@richardlau @MylesBorins
build: add vs2019 to vcbuild.bat help
f11406d 
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@richardlau @MylesBorins
build: remove enable_vtune from vcbuild.bat
55e2b4e 
vcbuild.bat wasn't updated when vtune support was removed in
#28522

Refs: #28522
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@richardlau @codebytere
build: add vs2019 to vcbuild.bat help
23761b3 
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@richardlau @codebytere
build: remove enable_vtune from vcbuild.bat
e883136 
vcbuild.bat wasn't updated when vtune support was removed in
#28522

Refs: #28522
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@richardlau @codebytere
build: add vs2019 to vcbuild.bat help
8296224 
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@richardlau @codebytere
build: remove enable_vtune from vcbuild.bat
e79f368 
vcbuild.bat wasn't updated when vtune support was removed in
#28522

Refs: #28522
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@richardlau richardlau

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@richardlau @nodejs-github-bot @Trott @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.