GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add missing code formatting in vm.md by cjihrig · Pull Request #31350 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

This commit adds missing code formatting in a few places in
the vm module documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

👍 here if you're OK with fast tracking this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devsnek and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. vm Issues and PRs related to the vm subsystem. labels Jan 14, 2020
devsnek
devsnek approved these changes Jan 14, 2020
View reviewed changes
Trott
Trott approved these changes Jan 14, 2020
View reviewed changes
trivikr
trivikr approved these changes Jan 14, 2020
View reviewed changes
BridgeAR
BridgeAR approved these changes Jan 14, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 14, 2020
lpinca
lpinca approved these changes Jan 14, 2020
View reviewed changes
@cjihrig
doc: add missing code formatting in vm.md
b4f5c9e 
This commit adds missing code formatting in a few places in
the vm module documentation.

PR-URL: nodejs#31350
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig cjihrig added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 15, 2020
@cjihrig
cjihrig force-pushed the docs branch from 07842ad to b4f5c9e Compare January 15, 2020 14:44
@cjihrig
cjihrig merged commit b4f5c9e into nodejs:master Jan 15, 2020
@cjihrig
cjihrig deleted the docs branch January 15, 2020 14:44
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@cjihrig @MylesBorins
doc: add missing code formatting in vm.md
aed00d7 
This commit adds missing code formatting in a few places in
the vm module documentation.

PR-URL: #31350
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
@codebytere codebytere added the dont-land-on-v12.x label Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@devsnek devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@cjihrig @Trott @lpinca @devsnek @BridgeAR @trivikr @codebytere @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.