GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update remark-preset-lint-node to 1.12.0 by Trott · Pull Request #31359 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 14, 2020

Copy link
Copy Markdown
Member

This adds linting for "hostname" in prose.

This also re-adds @zeit/ncc which is required to build. It was removed in 80fb153 but that was in error.

I'd like to fast-track this to prevent other instances of "hostname" from slipping in while this remains open. 👍 here to approve, or comment to block.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR and trivikr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 14, 2020
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed tools Issues and PRs related to the tools directory. labels Jan 14, 2020
BridgeAR
BridgeAR approved these changes Jan 14, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 14, 2020
@Trott

Trott commented Jan 15, 2020

Copy link
Copy Markdown
Member Author

@nodejs/linting
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Jan 15, 2020
View reviewed changes
@Trott

Trott commented Jan 15, 2020

Copy link
Copy Markdown
Member Author

Landed in 6623481...7ab33f2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit to Trott/io.js that referenced this pull request Jan 15, 2020
@Trott
tools: update remark-preset-lint-node to 1.12.0
b8eeb2d 
This adds linting for "hostname" in prose.

PR-URL: nodejs#31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott closed this Jan 15, 2020
@Trott
Trott force-pushed the lint-host-name branch from e10bf58 to 7ab33f2 Compare January 15, 2020 23:52
@Trott
Trott merged commit 7ab33f2 into nodejs:master Jan 15, 2020
@Trott
Trott deleted the lint-host-name branch January 15, 2020 23:52
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Trott @MylesBorins
tools: update remark-preset-lint-node to 1.12.0
29e0465 
This adds linting for "hostname" in prose.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Trott @MylesBorins
tools: remove obsolete dependencies
5dd6fb1 
Remove rollup dependencies in markdown linting tool's package.json. We
use @zeit/ncc.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Trott @codebytere
tools: update remark-preset-lint-node to 1.12.0
f01351f 
This adds linting for "hostname" in prose.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Trott @codebytere
tools: remove obsolete dependencies
9a6ae09 
Remove rollup dependencies in markdown linting tool's package.json. We
use @zeit/ncc.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
tools: update remark-preset-lint-node to 1.12.0
c7b1f1d 
This adds linting for "hostname" in prose.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
tools: remove obsolete dependencies
77e6700 
Remove rollup dependencies in markdown linting tool's package.json. We
use @zeit/ncc.

PR-URL: #31359
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @BridgeAR @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.