GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: add default type in getstringwidth.js by Trott · Pull Request #31377 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 16, 2020

Copy link
Copy Markdown
Member

This fixes a benchmark test that was recently broken by a breaking
change on the master branch.

Fixes: #31372

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Jan 16, 2020
@Trott Trott mentioned this pull request Jan 16, 2020
Investigate flaky test-benchmark-misc #31372
Closed
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 16, 2020
@Trott

Trott commented Jan 16, 2020

Copy link
Copy Markdown
Member Author

I'd like to fast-track this to unbreak nightly CI. Please 👍 here to approve (or comment to block).
BridgeAR, sam-github, and cjihrig reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jan 16, 2020

Copy link
Copy Markdown
Member Author

@BridgeAR @sam-github @AshCripps
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Jan 16, 2020
View reviewed changes
@Trott

Trott commented Jan 16, 2020

Copy link
Copy Markdown
Member Author

Benchmark tests CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11595/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sam-github
sam-github approved these changes Jan 16, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Jan 16, 2020
View reviewed changes
@mscdex

mscdex commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

It's probably better to throw instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Jan 16, 2020
View reviewed changes
@Trott

Trott commented Jan 16, 2020

Copy link
Copy Markdown
Member Author

It's probably better to throw instead.

Might be a good enhancement in the future. Before we can do that we'd need to:

  • Change the benchmark tests as described in Investigate flaky test-benchmark-misc  #31372 (comment) so that none of them depend on default options anymore
  • Add this "throw on undefined option" feature to the benchmark test runner (rather than inserting it into each and every benchmark)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit d2683ed into nodejs:master Jan 16, 2020
@Trott
Trott force-pushed the fix-getstringwidth branch from 3c7c340 to d2683ed Compare January 16, 2020 06:00
@Trott

Trott commented Jan 16, 2020

Copy link
Copy Markdown
Member Author

Landed in d2683ed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the fix-getstringwidth branch January 16, 2020 06:00
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Trott @MylesBorins
benchmark: add default type in getstringwidth.js
6e978f7 
This fixes a benchmark test that was recently broken by a breaking
change on the master branch.

Fixes: #31372

PR-URL: #31377
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
v13.7.0 proposal #31382
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Trott @codebytere
benchmark: add default type in getstringwidth.js
c7c0dfe 
This fixes a benchmark test that was recently broken by a breaking
change on the master branch.

Fixes: #31372

PR-URL: #31377
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
benchmark: add default type in getstringwidth.js
267a01f 
This fixes a benchmark test that was recently broken by a breaking
change on the master branch.

Fixes: #31372

PR-URL: #31377
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
v12.16.2 proposal #32313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@sam-github sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-benchmark-misc

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @mscdex @sam-github @cjihrig @richardlau @BridgeAR @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.