GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update ESLint to 7.0.0-alpha.2 by cjihrig · Pull Request #31400 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Jan 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Update ESLint to 7.0.0-alpha.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 17, 2020
@Trott

Trott commented Jan 17, 2020

Copy link
Copy Markdown
Member

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Jan 17, 2020

Copy link
Copy Markdown
Contributor Author

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

I'm fine with that approach. FWIW, in the past, we have updated to ESLint alpha releases as well.
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Jan 20, 2020
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Landing the updates incrementally allows us to adjust everything during the individual release and we could already use the changed features. The eslints changes are normally very stable, no matter that it's an alpha. I am fine with waiting or landing it right away therefore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 20, 2020
trivikr
trivikr approved these changes Jan 20, 2020
View reviewed changes

@trivikr trivikr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott approved these changes Jan 21, 2020
View reviewed changes
@cjihrig
cjihrig force-pushed the eslint branch from 95232f7 to f5822bd Compare February 15, 2020 14:55
@cjihrig cjihrig changed the title tools: update ESLint to 7.0.0-alpha.0 tools: update ESLint to 7.0.0-alpha.1 Feb 15, 2020
cjihrig added 5 commits February 28, 2020 17:03
@cjihrig
tools: update ESLint to 7.0.0-alpha.0
badac1f 
Update ESLint to 7.0.0-alpha.0
@cjihrig
tools: update ESLint to 7.0.0-alpha.1
4f867fd 
Update ESLint to 7.0.0-alpha.1
@cjihrig
tools: update ESLint to 7.0.0-alpha.2
78bceab 
Update ESLint to 7.0.0-alpha.2
@cjihrig
tools: enable default-case-last lint rule
c6325e2
@cjihrig
tools: enable no-useless-backreference lint rule
0bc8fe0
@cjihrig
cjihrig force-pushed the eslint branch from f5822bd to 0bc8fe0 Compare February 28, 2020 23:38
@cjihrig cjihrig changed the title tools: update ESLint to 7.0.0-alpha.1 tools: update ESLint to 7.0.0-alpha.2 Feb 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2020 •
edited by cjihrig
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29667/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @addaleax
tools: update ESLint to 7.0.0-alpha.0
7eaa813 
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @addaleax
tools: update ESLint to 7.0.0-alpha.1
2348ca0 
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member

Landed in 61f28fb...4f87b4f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @addaleax
tools: update ESLint to 7.0.0-alpha.2
6712e4a 
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @addaleax
tools: enable default-case-last lint rule
b4ca247 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @addaleax
tools: enable no-useless-backreference lint rule
4f87b4f 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig
cjihrig deleted the eslint branch March 11, 2020 16:02
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @MylesBorins
tools: update ESLint to 7.0.0-alpha.0
c70cfd2 
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @MylesBorins
tools: update ESLint to 7.0.0-alpha.1
cac1d01 
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @MylesBorins
tools: update ESLint to 7.0.0-alpha.2
814bb4a 
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @MylesBorins
tools: enable default-case-last lint rule
d3c4210 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@cjihrig @MylesBorins
tools: enable no-useless-backreference lint rule
35d0569 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
v13.11.0 proposal #32185
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
tools: update ESLint to 7.0.0-alpha.0
394fa1f 
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
tools: update ESLint to 7.0.0-alpha.1
e641b3c 
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
tools: update ESLint to 7.0.0-alpha.2
5dacfa7 
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
tools: enable default-case-last lint rule
bcf152e 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
tools: enable no-useless-backreference lint rule
ecf842e 
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjihrig @Trott @nodejs-github-bot @addaleax @BridgeAR @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.