GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: reland test refactoring by BridgeAR · Pull Request #31755 · nodejs/node

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Feb 12, 2020

Copy link
Copy Markdown
Member

#31396 was reverted in #31722. The issue was that WRK is not able to handle decimal times (and the minimum possible time is one second) and the threads must not be higher than the number of connections.

I just reverted the revert and added a fixup commit to fix the actual issue. The commit message might be changed during landing?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@BridgeAR
BridgeAR requested a review from addaleax February 12, 2020 20:04
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. buffer Issues and PRs related to the buffer subsystem. crypto Issues and PRs related to the crypto subsystem. http Issues and PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Feb 12, 2020
@BridgeAR
BridgeAR force-pushed the 2020-02-12-reland-benchmark-test-refactoring branch from 4bbf411 to 0074942 Compare February 12, 2020 20:05
@BridgeAR
BridgeAR requested review from Trott and sam-github February 12, 2020 22:03
addaleax
addaleax approved these changes Feb 12, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29088/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Feb 12, 2020 •
edited by BridgeAR
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Benchmark test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12163/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mscdex
mscdex reviewed Feb 12, 2020
View reviewed changes
Comment thread benchmark/run.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Feb 13, 2020

Copy link
Copy Markdown
Member Author

Benchmark CI https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12185/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 13, 2020
vdeturckheim
vdeturckheim approved these changes Feb 14, 2020
View reviewed changes
Trott
Trott approved these changes Feb 15, 2020
View reviewed changes
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 9, 2020
@addaleax

addaleax commented Mar 9, 2020

Copy link
Copy Markdown
Member

This needs a rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR added 6 commits March 9, 2020 14:07
@BridgeAR
Revert "Revert "benchmark: refactor helper into a class""
bb43941 
This reverts commit 5b0308c.
@BridgeAR
Revert "Revert "benchmark: add test and all options and improve e…
41834c5 
…rrors""

This reverts commit 4671d55.
@BridgeAR
Revert "Revert "test: refactor all benchmark tests to use the new tes…
ac2514b 
…t option""

This reverts commit aa0a01b.
@BridgeAR
Revert "Revert "benchmark: remove special test entries""
64a9464 
This reverts commit 7cfbc9f.
@BridgeAR
fixup: "benchmark: add test and all options and improve errors"
626a7bf
@BridgeAR
fixup: address comment
778b2a6
@BridgeAR
BridgeAR force-pushed the 2020-02-12-reland-benchmark-test-refactoring branch from 5b12cbc to 778b2a6 Compare March 9, 2020 13:10
@BridgeAR

BridgeAR commented Mar 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12703/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 9, 2020
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
benchmark: refactor helper into a class
f64aafa 
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
benchmark: add test and all options and improve errors"
1760c23 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
test: refactor all benchmark tests to use the new test option
9e40df7 
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
benchmark: remove special test entries
bb6125b 
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR

BridgeAR commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

Landed in 9e69d97...bb6125b 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Mar 9, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
benchmark: refactor helper into a class
e11f38c 
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
benchmark: add test and all options and improve errors"
5d92cec 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
test: refactor all benchmark tests to use the new test option
92cc406 
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
benchmark: remove special test entries
ddb8824 
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
v13.11.0 proposal #32185
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-blocked-v12.x labels Apr 20, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
benchmark: refactor helper into a class
900cf06 
This reverts commit 5b0308c.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
benchmark: add test and all options and improve errors"
51e2427 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
test: refactor all benchmark tests to use the new test option
8e59077 
This reverts commit aa0a01b.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
benchmark: remove special test entries
1b0b817 
This reverts commit 7cfbc9f.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
benchmark: refactor helper into a class
011e3de 
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
benchmark: add test and all options and improve errors"
7139788 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
test: refactor all benchmark tests to use the new test option
5a8e54b 
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
benchmark: remove special test entries
b4a6351 
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
@lundibundi lundibundi mentioned this pull request Sep 3, 2020
[v14.x backport] stream: simpler and faster Readable async iterator #34887
Closed
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@sam-github sam-github Awaiting requested review from sam-github
+2 more reviewers
@mscdex mscdex mscdex left review comments
@vdeturckheim vdeturckheim vdeturckheim approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. buffer Issues and PRs related to the buffer subsystem. crypto Issues and PRs related to the crypto subsystem. http Issues and PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@BridgeAR @nodejs-github-bot @addaleax @mscdex @Trott @vdeturckheim @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.