GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v12.x backport] events: allow monitoring error events by Flarna · Pull Request #32004 · nodejs/node

Conversation

@Flarna

@Flarna Flarna commented Feb 28, 2020

Copy link
Copy Markdown
Member

Backport #30932 to v12 as it was reverted in 12.16.1 (see #30932 (comment)).

To avoid the issue seen in 12.16.0 I added the changes from #31848 on top.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to EventEmitter and the events module. v12.x labels Feb 28, 2020
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 7, 2020
BridgeAR
BridgeAR approved these changes Mar 9, 2020
View reviewed changes
@codebytere
codebytere force-pushed the v12.x-staging branch from a01fb4a to e5dc2fb Compare March 23, 2020 16:01
@codebytere
codebytere force-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190 Compare March 31, 2020 23:57
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30480/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Flarna added 3 commits April 6, 2020 21:10
@Flarna
events: allow monitoring error events
1c14d65 
Installing an error listener has a side effect that emitted errors are
considered as handled. This is quite bad for monitoring/logging tools
which tend to be interested in errors but don't want to cause side
effects like swallow an exception.

There are some workarounds in the wild like monkey patching emit or
remit the error if monitoring tool detects that it is the only listener
but this is error prone and risky.

This PR allows to install a listener to monitor errors with the side
effect to consume the error. To avoid conflicts with other events it
exports a symbol on EventEmitter which owns this special meaning.

Refs: open-telemetry/opentelemetry-js#225

PR-URL: nodejs#30932
Refs: open-telemetry/opentelemetry-js#225
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Flarna
events: convert errorMonitor to a normal property
c483e6d 
Convert property errorMonitor to a normal property as non-writable
caused unwanted side effects.

Refs: nodejs#30932 (comment)
@Flarna
fixup! events: allow monitoring error events
a9356f4
@Flarna
Flarna force-pushed the v12-backport-eventmonitor branch from 11e93b0 to a9356f4 Compare April 6, 2020 19:11
@Flarna
change common.expectsError to assert.throws
4912594
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30531/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30559/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30560/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna Flarna added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 8, 2020
@Flarna Flarna mentioned this pull request Apr 20, 2020
events: convert errorMonitor to normal property #31848
Closed
2 tasks done
@legendecas

legendecas commented Apr 25, 2020

Copy link
Copy Markdown
Member

The CI links above are 404-ish. Is there any stale scavenger cleaning outdated CI results? 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna

Flarna commented Apr 25, 2020

Copy link
Copy Markdown
Member Author

12.17.0 is planned mid/end of may therefore CI can wait at bit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Flarna @targos
events: allow monitoring error events
c49889f 
Installing an error listener has a side effect that emitted errors are
considered as handled. This is quite bad for monitoring/logging tools
which tend to be interested in errors but don't want to cause side
effects like swallow an exception.

There are some workarounds in the wild like monkey patching emit or
remit the error if monitoring tool detects that it is the only listener
but this is error prone and risky.

This PR allows to install a listener to monitor errors with the side
effect to consume the error. To avoid conflicts with other events it
exports a symbol on EventEmitter which owns this special meaning.

Refs: open-telemetry/opentelemetry-js#225

Backport-PR-URL: nodejs#32004
PR-URL: nodejs#30932
Refs: open-telemetry/opentelemetry-js#225
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos

targos commented Apr 25, 2020

Copy link
Copy Markdown
Member

thanks @Flarna. Landed on my release preparation branch: https://github.com/targos/node/commits/prepare-minor
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Apr 25, 2020
targos pushed a commit that referenced this pull request Apr 28, 2020
@Flarna @targos
events: allow monitoring error events
8c497f8 
Installing an error listener has a side effect that emitted errors are
considered as handled. This is quite bad for monitoring/logging tools
which tend to be interested in errors but don't want to cause side
effects like swallow an exception.

There are some workarounds in the wild like monkey patching emit or
remit the error if monitoring tool detects that it is the only listener
but this is error prone and risky.

This PR allows to install a listener to monitor errors with the side
effect to consume the error. To avoid conflicts with other events it
exports a symbol on EventEmitter which owns this special meaning.

Refs: open-telemetry/opentelemetry-js#225

Backport-PR-URL: #32004
PR-URL: #30932
Refs: open-telemetry/opentelemetry-js#225
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Flarna
Flarna deleted the v12-backport-eventmonitor branch June 3, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. events Issues and PRs related to EventEmitter and the events module. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Flarna @nodejs-github-bot @legendecas @targos @BridgeAR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.