GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: introduce node_sockaddr by jasnell · Pull Request #32070 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 3, 2020

Copy link
Copy Markdown
Member

Extracted from the QUIC PR to allow for more incremental review.

Introduce the SocketAddress utility class. While not specific to QUIC, the QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Mar 3, 2020
@jasnell
jasnell requested a review from addaleax March 3, 2020 20:00
devnexen
devnexen approved these changes Mar 3, 2020
View reviewed changes
@jasnell
jasnell force-pushed the node_sockaddr branch from 924cd77 to cc7b312 Compare March 3, 2020 21:51
richardlau
richardlau approved these changes Mar 3, 2020
View reviewed changes
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 3, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29526/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 3, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29528/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 4, 2020

Copy link
Copy Markdown
Member Author

Relevant build failure on macos... hopefully fixed up.. trying again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29536/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 4, 2020

Copy link
Copy Markdown
Member Author

this is ready to go as soon as the 48 hours is up :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lundibundi
lundibundi approved these changes Mar 5, 2020
View reviewed changes
Comment thread src/node_sockaddr-inl.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
src: introduce node_sockaddr
26454dc 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the node_sockaddr branch from 0cb1d1b to 26454dc Compare March 5, 2020 19:45
jasnell added a commit that referenced this pull request Mar 5, 2020
@jasnell
src: introduce node_sockaddr
ba462c2 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@jasnell

jasnell commented Mar 5, 2020

Copy link
Copy Markdown
Member Author

Landed in ba462c2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Mar 5, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@jasnell @MylesBorins
src: introduce node_sockaddr
4ac1ce1 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
v13.11.0 proposal #32185
Merged
@targos targos added the backport-blocked-v12.x label Apr 20, 2020
@targos

targos commented Apr 20, 2020

Copy link
Copy Markdown
Member

Depends on #31871 to land on v12.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: introduce node_sockaddr
372d30c 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: introduce node_sockaddr
83c47b6 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes
+2 more reviewers
@devnexen devnexen devnexen approved these changes
@lundibundi lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jasnell @nodejs-github-bot @targos @addaleax @devnexen @richardlau @lundibundi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.