GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: improve Buffer documentation by addaleax · Pull Request #32086 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Mar 4, 2020

Copy link
Copy Markdown
Member

Various improvements to the Buffer docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR and vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@addaleax
doc: improve Buffer documentation
5eac91a 
Various improvements to the Buffer docs.
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Mar 4, 2020
jasnell
jasnell approved these changes Mar 4, 2020
View reviewed changes
@addaleax
fixup! doc: improve Buffer documentation
9c85a8a
@addaleax

addaleax commented Mar 7, 2020

Copy link
Copy Markdown
Member Author

@jasnell I’ve updated this based on feedback I’ve received in private, feel free to take another look :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax
fixup! fixup! doc: improve Buffer documentation
8cc28ab
@addaleax
addaleax force-pushed the buffer-doc-rewrite branch from cb995aa to 8cc28ab Compare March 7, 2020 11:42
@addaleax

addaleax commented Mar 10, 2020

Copy link
Copy Markdown
Member Author

@nodejs/documentation
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 10, 2020

Copy link
Copy Markdown
Member

Still LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 11, 2020
@addaleax

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

Landed in c41e360
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 11, 2020
addaleax added a commit that referenced this pull request Mar 11, 2020
@addaleax
doc: improve Buffer documentation
c41e360 
Various improvements to the Buffer docs.

PR-URL: #32086
Reviewed-By: James M Snell <[email protected]>
@addaleax
addaleax deleted the buffer-doc-rewrite branch March 11, 2020 16:07
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@addaleax @MylesBorins
doc: improve Buffer documentation
5bc5161 
Various improvements to the Buffer docs.

PR-URL: #32086
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
v13.11.0 proposal #32185
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
doc: improve Buffer documentation
8602392 
Various improvements to the Buffer docs.

PR-URL: #32086
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@addaleax @jasnell @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.