GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clear up child_process command resolution by lundibundi · Pull Request #32091 · nodejs/node

Conversation

@lundibundi

@lundibundi lundibundi commented Mar 4, 2020

Copy link
Copy Markdown
Member

Fixes: #20605
Refs: libuv/libuv#1837

/cc @richardlau @nodejs/platform-windows @nodejs/documentation @nodejs/child_process

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lundibundi
doc: clear up child_process command resolution
9e0f530 
Fixes: nodejs#20605
Refs: libuv/libuv#1837
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to Node.js documentation. labels Mar 4, 2020
addaleax
addaleax reviewed Mar 4, 2020
View reviewed changes
Comment thread doc/api/child_process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lundibundi @addaleax
fixup! update doc/api/child_process.md
fc57863 
Co-Authored-By: Anna Henningsen <[email protected]>
richardlau
richardlau reviewed Mar 4, 2020
View reviewed changes
Comment thread doc/api/child_process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Mar 4, 2020
View reviewed changes
bzoz
bzoz approved these changes Mar 5, 2020
View reviewed changes

@bzoz bzoz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/child_process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Mar 5, 2020
View reviewed changes
BridgeAR
BridgeAR approved these changes Mar 9, 2020
View reviewed changes
@lundibundi
fixup! Update doc/api/child_process.md
5926380
@lundibundi lundibundi added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 11, 2020
@addaleax

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member

Landed in 4b84010
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@lundibundi @addaleax
doc: clear up child_process command resolution
4b84010 
Fixes: #20605
Refs: libuv/libuv#1837

PR-URL: #32091
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@lundibundi @MylesBorins
doc: clear up child_process command resolution
ae69f97 
Fixes: #20605
Refs: libuv/libuv#1837

PR-URL: #32091
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@lundibundi @MylesBorins
doc: clear up child_process command resolution
af73ed6 
Fixes: #20605
Refs: libuv/libuv#1837

PR-URL: #32091
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
v13.11.0 proposal #32185
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@lundibundi @targos
doc: clear up child_process command resolution
11899f6 
Fixes: #20605
Refs: libuv/libuv#1837

PR-URL: #32091
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@richardlau richardlau mentioned this pull request Aug 7, 2020
child_process spawn does not pass environment key-value pairs on Windows #34667
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@bzoz bzoz bzoz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Questionable internal casing of property name process.env.Path

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@lundibundi @addaleax @lpinca @richardlau @BridgeAR @bzoz @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.