GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — doc: remove personal pronouns in reference docs prose by Trott · Pull Request #32142 · nodejs/node Conversation
Member
Per style guide, avoid personal pronouns in reference docs, hopefully without introducing a ton of passive voice. Lint rule is possible, but I personally want to take some time to make sure this isn't a guideline we want to keep. For now, though, abide by it. Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
tniessen
approved these changes
BridgeAR
approved these changes
trivikr
approved these changes
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
doc
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 6 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |