GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — meta: move inactive collaborators to emeriti by Trott · Pull Request #32151 · nodejs/node

Conversation

Trott commented Mar 8, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

@claudiorodriguez @iarna @italoacasas @MoonBall @rubys @seishun @trevnorris If any of you wish to remain collaborators for any reason whatsoever, just let me know in the next 72 hours and I'll remove you from this PR. (You don't even have to tell me what the reason is. Leave a comment here or send me an email.)

Thanks for all the great contributions and collaboration over the years!

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label

Mar 8, 2020

tniessen approved these changes

Mar 9, 2020

View reviewed changes

Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 9, 2020

trivikr approved these changes

Mar 9, 2020

View reviewed changes

Trott commented Mar 10, 2020

Copy link

Copy Markdown

Member Author

@nodejs/tsc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina approved these changes

Mar 10, 2020

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rubys commented Mar 10, 2020

Copy link

Copy Markdown

Member

I wish to remain a collaborator.

Trott and jasnell reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 10, 2020

jasnell previously requested changes

Mar 10, 2020

View reviewed changes

jasnell left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given @rubys' request to remain, just making the -1 explicit until the PR is updated to reflect that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Trott force-pushed the emeritus-mar-2020 branch from 99f9096 to ed47c2c Compare

March 11, 2020 02:20

Trott dismissed jasnell’s stale review

March 11, 2020 02:21

Restored rubys

Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 11, 2020

jasnell approved these changes

Mar 11, 2020

View reviewed changes

tniessen approved these changes

Mar 11, 2020

View reviewed changes

hiroppy approved these changes

Mar 11, 2020

View reviewed changes

Trott commented Mar 11, 2020

Copy link

Copy Markdown

Member Author

@seishun sent me an email saying they want to remain a collaborator, so I'll update this....

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 11, 2020

Trott force-pushed the emeritus-mar-2020 branch from ed47c2c to 8924c91 Compare

March 12, 2020 04:40

Trott commented Mar 12, 2020

Copy link

Copy Markdown

Member Author

Restored @seishun. This should be ready to land. One more approval or re-approval for good measure would be great.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott force-pushed the emeritus-mar-2020 branch from 8924c91 to a99778e Compare

March 12, 2020 04:44

MylesBorins approved these changes

Mar 12, 2020

View reviewed changes

MylesBorins left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

so long and thanks for all the commits

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          meta: move inactive collaborators to emeriti

e6a55b4

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32151
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

Trott force-pushed the emeritus-mar-2020 branch from a99778e to e6a55b4 Compare

March 12, 2020 05:37

Trott merged commit e6a55b4 into nodejs:master

Mar 12, 2020

Trott commented Mar 12, 2020

Copy link

Copy Markdown

Member Author

Landed in e6a55b4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott deleted the emeritus-mar-2020 branch

March 12, 2020 05:38

BridgeAR pushed a commit that referenced this pull request

Mar 17, 2020


          meta: move inactive collaborators to emeriti

5b9ce00

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32151
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

MylesBorins mentioned this pull request

Mar 19, 2020

v13.12.0 proposal #32376

Merged

MylesBorins pushed a commit that referenced this pull request

Mar 24, 2020


          meta: move inactive collaborators to emeriti

397cbca

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32151
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

targos pushed a commit that referenced this pull request

Apr 22, 2020


          meta: move inactive collaborators to emeriti

4d0be3d

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32151
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

targos mentioned this pull request

Apr 22, 2020

v12.16.3 release proposal #33009

Merged

iuliana-prodan mentioned this pull request

Jul 15, 2026

Define criteria for marking maintainers inactive zephyrproject-rtos/zephyr#113534

Closed

Reviewers

mcollina

mcollina approved these changes

jasnell

jasnell approved these changes

tniessen

tniessen approved these changes

trivikr

trivikr approved these changes

+2 more reviewers

MylesBorins

MylesBorins approved these changes

hiroppy

hiroppy approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Trott commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Trott commented Mar 10, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

rubys commented Mar 10, 2020

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Mar 11, 2020

Uh oh!

Trott commented Mar 12, 2020

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Mar 12, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Trott commented Mar 8, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.